-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading non-ASCII characters encoded as UTF-8 doesn’t work well #19
Comments
Yeah, if you open |
I experimented a little and made a short patch that fixed this. I guess I should submit a PR? Edit: It’s actually looking a little trickier than I thought. I wonder if making |
Yep, PRs are more than welcome! I actually used to have |
|
Ok, these are some good points. This is definitely worth looking into. Shouldn't be a huge task in converting to use |
This changes the editor to represent lines as `String`s. It’s possible that this will have to change in the future if we want to support reading non-UTF-8 files, but I think this is a good fix for now at least. It also changes the represntation of keys to be either a character or a ‘special’ key that doesn’t represent a character. This means that all characters should now be typable. Fixes gchp#19. Fixes gchp#17.
This changes the editor to represent lines as `String`s. It’s possible that this will have to change in the future if we want to support reading non-UTF-8 files, but I think this is a good fix for now at least. It also changes the represntation of keys to be either a character or a ‘special’ key that doesn’t represent a character. This means that all characters should now be typable. Fixes gchp#19. Fixes gchp#17.
I’m not sure what the precise issue is, but loading UTF-8-encoded files with non-ASCII characters in them doesn’t work well. As a simple example, writing
ÿ
to a file with a different editor and then loading that file with Iota shows garbled text.The text was updated successfully, but these errors were encountered: