Add more image operations #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rewrote QR code parsing to be more readable and actually error out properly.
("borrowed" from RenderImage)
Included variants of the Roboto fonts as bitmap fonts for jimp. Changed webpack config to import the font files.
Changed SharpenImage to use the new algorithm.
mattnotmitt
approved these changes
Mar 19, 2019
| self.sendStatusMessage("Adding text to image..."); | ||
|
|
||
| const fontsMap = { | ||
| "Roboto": await import(/* webpackMode: "eager" */ "../../web/static/fonts/bmfonts/Roboto72White.fnt"), |
There was a problem hiding this comment.
Maybe use Promise.all here so we're not awaiting for each of these to load individually? Not sure whether webpack will be friends with that though...
There was a problem hiding this comment.
Would something like this be better? Webpack seems to be happy with it.
const fontsMap = {};
const fonts = [
import(/* webpackMode: "eager" */ "../../web/static/fonts/bmfonts/Roboto72White.fnt"),
...
];
await Promise.all(fonts)
.then(fonts => {
fontsMap.Roboto = fonts[0];
...
});
const fontImages = [
import(/* webpackMode: "eager" */ "../../web/static/fonts/bmfonts/Roboto72White.png"),
...
];
await Promise.all(fontImages);Also minor corrections to jsdocs in ImageManipulation
Change QR code ops to use ArrayBuffer. Add new function to Utils to convert a string to arraybuffer.
Now resizes the text instead of the image
|
Ready to merge this. We just need to fix the conflict and I'm also getting a bug in the 'Add text to image' op: |
Fix reading QR codes with transparent backgrounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 more image operations (Sharpen image and Convert image format).
Sadly Jimp doesn't support outputting as GIF so we're limited to JPEG, PNG, BMP and TIFF.