Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PGP verify operation #585

Merged
merged 2 commits into from Jul 3, 2019
Merged

Added PGP verify operation #585

merged 2 commits into from Jul 3, 2019

Conversation

mattnotmitt
Copy link
Collaborator

Additionally added some more metadata to PGP Decrypt and Verify operation.
Fixes #581.
2019-06-27-165235_3830x2065_scrot

Added some more metadata to decrypt & verify
Fixes gchq#581
@mattnotmitt
Copy link
Collaborator Author

Meant to say, I looked into implementing a PGP (clear)Sign operation however according to keybase/kbpgp#138 (comment) it's not been implemented sadly. I might look into contributing it to upstream if there's want for it.

@jdgregson
Copy link

@artemisbot There is want for it from me, for what it's worth. The only interaction I usually have with PGP is receiving PGP-signed messages from some mailing lists. I have Outlook set up to verify them automatically, but it would be nice to be able to do this in CyberChef when I'm using a client without PGP signature verification configured.

@mattnotmitt
Copy link
Collaborator Author

@jdgregson in this situation why would you need a clearsign op? Unless you're wanting to sign replies yourself - I would want to implement this in a new PR though.

@n1474335 n1474335 merged commit c46928a into gchq:master Jul 3, 2019
@n1474335
Copy link
Member

n1474335 commented Jul 3, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PGP signature verfication
3 participants