Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FederatedOperationHandler Retains information from previous operation. #3084

Open
GCHQDev404 opened this issue Nov 14, 2023 · 2 comments
Open
Labels
bug Confirmed or suspected bug
Milestone

Comments

@GCHQDev404
Copy link
Contributor

GCHQDev404 commented Nov 14, 2023

Describe the bug
The FederatedOperationHandler has retains a field called graphs and context which persists for the life of the Handler within the FederatedStore, retaining information from the previous execution.

Expected behaviour
Handler should not retain state from the previous execution.

@GCHQDev404 GCHQDev404 added the bug Confirmed or suspected bug label Nov 14, 2023
@GCHQDev404 GCHQDev404 changed the title FederatedOperation Retains Graph information FederatedOperationHandler Retains Graph information Nov 14, 2023
@GCHQDev404
Copy link
Contributor Author

Same issue happens with the context field within this class. But that was introduced earlier.

@GCHQDev404 GCHQDev404 changed the title FederatedOperationHandler Retains Graph information FederatedOperationHandler Retains information from previous operation. Nov 15, 2023
@t92549
Copy link
Contributor

t92549 commented Nov 15, 2023

A potential solution is to just pass the graphs in to getAllGraphResults and mergeResults as parameters, and not keep them around at all between runs.

@GCHQDeveloper314 GCHQDeveloper314 added this to the Backlog milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug
Projects
None yet
Development

No branches or pull requests

3 participants