Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetElementsIT should fully test matchedVertex #3138

Open
t92549 opened this issue Dec 18, 2023 · 0 comments
Open

GetElementsIT should fully test matchedVertex #3138

t92549 opened this issue Dec 18, 2023 · 0 comments
Labels
enhancement Improvement to existing functionality/feature

Comments

@t92549
Copy link
Contributor

t92549 commented Dec 18, 2023

#3131 adds testing of matchedVertex to Gaffer tests but does not fully add it for GetElementsIT:

if (includeEdges && inOutType == IncludeIncomingOutgoingType.INCOMING) {
ElementUtil.assertElementEquals(expectedElements, resultsSeed, true);
ElementUtil.assertElementEquals(expectedElements, resultsElement, true);
} else {
ElementUtil.assertElementEqualsIncludingMatchedVertex(expectedElements, resultsSeed, true);
ElementUtil.assertElementEqualsIncludingMatchedVertex(expectedElements, resultsElement, true);
}

This is because the test never had the correct expected data as they never tested matchedVertex correctly. Therefore, the tests should be refactored and expect the correct data, and enable the matchedVertex check.

@t92549 t92549 added the enhancement Improvement to existing functionality/feature label Dec 18, 2023
@t92549 t92549 added this to the v2.2.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature
Projects
None yet
Development

No branches or pull requests

2 participants