Gh-3166: FederatedStore While Operation Looping Bug #3167
Conversation
…join or while loop. Other information should be retained.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3167 +/- ##
=============================================
- Coverage 66.68% 66.68% -0.01%
+ Complexity 2557 2555 -2
=============================================
Files 907 909 +2
Lines 29068 29076 +8
Branches 3241 3241
=============================================
+ Hits 19385 19389 +4
- Misses 8249 8251 +2
- Partials 1434 1436 +2 ☔ View full report in Codecov by Sentry. |
GCHQDeveloper314
changed the title
…ration-looping-bug' into gh-3166-FederatedStore-while-operation-looping-bug
| } | ||
|
|
||
| return input; | ||
| } | ||
|
|
||
| protected Operation getOperationFromWhile(final While aWhile) { |
There was a problem hiding this comment.
Maybe a comment to explain this is useful for overriding (in Federation)?
There was a problem hiding this comment.
I thought the rule was anything Federation should not be mentioned lower down in the Gaffer code?
Thoughts?
There was a problem hiding this comment.
I don't think we should mention Federation in the core code. It is an additional store which shouldn't require changes to the core or mentions of Federation. In practice there are a few things like this. It will be easy to find out what this is for. A general JavaDoc comment would be good but a comment which just says that it's there for Federation less so.
...ted-store/src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedWhileLoopAndJoinTest.java
Outdated
Show resolved
Hide resolved
Related issue