Gh-3187: Add Open Telemetry proof of concept #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3189 +/- ##
==========================================
Coverage 66.70% 66.70%
+ Complexity 2559 2558 -1
==========================================
Files 907 908 +1
Lines 29076 29113 +37
Branches 3241 3243 +2
==========================================
+ Hits 19396 19421 +25
- Misses 8248 8259 +11
- Partials 1432 1433 +1 ☔ View full report in Codecov by Sentry. |
GCHQDeveloper314
changed the title
GCHQDeveloper314
approved these changes
Apr 12, 2024
cn337131
approved these changes
Apr 16, 2024
l46978
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic implementation of Open Telemetry that will record Spans across executions of Operations/OperationChains. Can be toggled on via a
otelActiveoption in thegraphConfig.json(off by default). Hopefully is a useful start point to be expanded on if required.Is difficult one to demonstrate via unit testing but been manually tested to ensure Spans look useful with relevant data via a
JaegerUI. Uses the auto configure feature of Open Telemetry so can be easily configured where and how to export data to via environment variables e.g.OTEL_SERVICE_NAME=gaffer-rest- sets the service name togaffer-restOTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://jaeger:4317- sets the endpoint to export traces to e.g.JaegerOTEL_TRACES_EXPORTER=console- sets the exporter to console rather than the default of OTEL (needs to be OTEL to work with Jaeger).Related issue