Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GF Config: View Existing Dashboards #295

Closed
daisycrego opened this issue Apr 4, 2020 · 1 comment · Fixed by #294
Closed

GF Config: View Existing Dashboards #295

daisycrego opened this issue Apr 4, 2020 · 1 comment · Fixed by #294
Assignees
@daisycrego
Labels
Front End Team
Milestone
Sprint 5 - Frontend

Comments

@daisycrego
Copy link
Contributor

daisycrego commented Apr 4, 2020 •
edited

User story
As a User, I want to view all of my event dashboards on mercury so that I can add and remove sensors or reset the dashboard entirely.

Acceptance criteria
User can view existing event dashboards per GFConfig.

Definition of Done
GFConfig view is updated to display all of the Grafana dashboards
In each view, there is 1 form per dashboard, which will allow the user to:

  • choose which sensors to include in the dashboard
  • reset an individual dashboard (give the dashboard all sensors)
  • delete an individual dashboard
@daisycrego daisycrego added the question Further information is requested label Apr 4, 2020
@daisycrego daisycrego self-assigned this Apr 4, 2020
daisycrego added a commit that referenced this issue Apr 4, 2020
@daisycrego
Initial commit for #295: GF Config: View Existing Dashboards
828ddfc 
- Update ag_data.models.AGSensor to include a __str__ method - needed for display purposes.
- Create a ModelForm to allow the user to select which sensors to include in a dashboard.
- Change some names in the Grafana API for clarity
- Modify Grafana.delete_all_panels (deleting by dashboard uid) to delete by dashboard name, because this will make the method more useful.
- Add Grafana.update_dashboard_panels(), which takes a dashboard/event name and array of sensors and updates the Event dashboard on Grafana with the new set of sensors.
- Add Grafana.get_all_sensors(), which returns a list of all current sensors in a given dashboard.
- Update GFConfig GET view to return data for each dashboard to the context, as well as DashboardSensorPanelsForm forms initialized with the existing sensors.
- Update gfconfig template to display a form for each dashboard listing all panels, with the panels actually present in the dashboard checked.
- Add Update/Refresh/Delete buttons to sensor forms.
daisycrego added a commit that referenced this issue Apr 4, 2020
@daisycrego
Issue #295: Add test of updated GFConfig view: If a dashboard exists,…
a1e2ede 
… its name and sensor(s) are passed to the template and displayed.
@daisycrego daisycrego linked a pull request Apr 4, 2020 that will close this issue
Issue #225: Creating a GFConfig triggers creation of Event dashboards/Sensor panels for all existing events/sensors. Issue #295: View Existing Dashboards in GFConfig view #294
Merged
@daisycrego
Copy link
Contributor Author

image

@daisycrego daisycrego added this to the Sprint 5 - Frontend milestone Apr 4, 2020
daisycrego added a commit that referenced this issue Apr 4, 2020
@daisycrego
Issue #295: Improve test of GFConfig GET view to confirm that the cor…
f8326cc 
…rect ModelForm type was passed to the template.
daisycrego added a commit that referenced this issue Apr 5, 2020
@daisycrego
Issue #295: Add update_dashboard function to GFConfig view - when upd…
e8b234a 
…ate button is pressed, dashboard is updated to include only the currently selected sensor panels.
daisycrego added a commit that referenced this issue Apr 5, 2020
@daisycrego
Issue #295: Add a CustomModelChoiceField class which extends ModelMul…
71c5213 
…tipleChoiceField to provide labels for the sensors displayed by DashboardSensorPanelsForm. This is a better alternative to adding a __str__ method to the AGSensor model for processing form submissions. Remove __str__ method of ag_data.models.AGSensor. Add tests for Update Dashboard Panels to remove all panels, keep all panels, and keep only a subset of panels.
daisycrego added a commit that referenced this issue Apr 5, 2020
@daisycrego
Issue #295: Reset Dashboards view: Created a new view for handling da…
abf52f4 
…shboard resets. Add a test which sets the panels in the dashboard to a subset of the total panels, then uses reset to restore all panels to the dashboard.
daisycrego added a commit that referenced this issue Apr 5, 2020
@daisycrego
Issue #295: Add delete dashboard feature to GFConfig Dashboards view.…
c094010 
… Add test of delete feature which deletes a dashboard and confirms delete operation returns True
@daisycrego daisycrego added Front End Team and removed question Further information is requested labels Apr 5, 2020
sunnybansal added a commit that referenced this issue Apr 5, 2020
@sunnybansal
Merge pull request #294 from gcivil-nyu-org/grafana
0ab2884 
Issue #225: Creating a GFConfig triggers creation of Event dashboards/Sensor panels for all existing events/sensors. Issue #295: View Existing Dashboards in GFConfig view
daisycrego added a commit that referenced this issue Apr 8, 2020
@daisycrego
#295 Support multiple GFConfigs.
0218feb
@daisycrego daisycrego reopened this Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daisycrego daisycrego

Labels
Front End Team
Projects
None yet
Milestone
Sprint 5 - Frontend
1 participant
@daisycrego