Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grafana API improvements #232

Merged
merged 9 commits into from
Mar 29, 2020
Merged

Grafana API improvements #232

merged 9 commits into from
Mar 29, 2020

Commits on Mar 28, 2020

  1. Add tests of GFConfig view to GET and POST from the view, confirm tha… 

    …t expected error messages are displayed, confirm that a GFConfig object can be created successfully.
    @daisycrego
    daisycrego committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    03b96bb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'frontend-team' into grafana

    @daisycrego
    daisycrego committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    54110d3 View commit details
    Browse the repository at this point in the history

  3. Black and flake8.

    @daisycrego
    daisycrego committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    e5d13b6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'grafana' of https://github.com/gcivil-nyu-org/spring202… 

    …0-cs-gy-9223-class into grafana

Sync up with frontend-team.
    @daisycrego
    daisycrego committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    ff56c3d View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2020

  1. Change Grafana class to access a GFConfig object in its constructor. … 

    …Modify all tests and views that create a Grafana instance so that they first create a GFConfig. Condense code for building API endpoint urls. Fix issue with events test that was leading to Quota reached API failures (some tests were creating dashboards but not cleaning them up).
    @daisycrego
    daisycrego committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    715fb2f View commit details
    Browse the repository at this point in the history

  2. Change GFConfig view and its tests to reflect change in Grafana class… 

    …: Grafana constructor now takes a GFConfig object directly.
    @daisycrego
    daisycrego committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    31cf3a8 View commit details
    Browse the repository at this point in the history

  3. Add documentation to grafana test.

    @daisycrego
    daisycrego committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    b5503e2 View commit details
    Browse the repository at this point in the history

  4. Add documentation to grafana API and tests. Added helper function to … 

    …reduce code reuse across tests.
    @daisycrego
    daisycrego committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    ac350c3 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #229 from gcivil-nyu-org/grafana 

    GFConfig testing; Change Grafana class to take GFConfig in constructor; Fix issue with API tests causing Quota Reached error
    @tianrunw
    tianrunw committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    10f2505 View commit details
    Browse the repository at this point in the history