-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend team #247
Merged
Merged
Frontend team #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oesn't have to retype the inputs.
…ften won't have access to the dashboard UID, only the current event name, so add_panel should take care of locating the appropriate UID before updating the dashboard. Added a get_dashboard_by_event_name function which will take an event name and find the dashboard. Update ConfigureSensors view with some placeholders to support adding new Sensors to the currently active event dashboard. Waiting on implementation of Active Event, but for now the first event queried will be used as the active event. Updated tests and features that referenced the old version of Grafana.add_panel().
…ents - no longer need uid.
View new sensor models
remove summary: simulator, dashboard, can, stopwatch
Remove unwanted code from mercury.
JS Fix to issue of all div's loading for configure sensors upon click…
Merge branch 'master' into frontend-team
Frontend team sync - Get frontend-team in sync with master before merging
dandipietrantonio
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! coverage should go up after merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.