Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymmetricDS configuration script (revision 2) #318

Merged
merged 11 commits into from
Apr 7, 2020
Merged

SymmetricDS configuration script (revision 2) #318

merged 11 commits into from
Apr 7, 2020

Conversation

alldne
Copy link
Contributor

@alldne alldne commented Apr 7, 2020 •
edited

@alldne alldne changed the title Backend/symd configuration SymmetricDS configuration script (revision 2) Apr 7, 2020
@alldne alldne requested a review from Ricardo-1894 April 7, 2020 15:26
Ricardo-1894
Ricardo-1894 approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@Ricardo-1894 Ricardo-1894 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ziheng-Wang
Ziheng-Wang approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@Ziheng-Wang Ziheng-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on MacOS, approved, feel free to merge.

@alldne alldne merged commit 4129d07 into backend-team Apr 7, 2020
@alldne alldne deleted the backend/symd-configuration branch April 7, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ricardo-1894 Ricardo-1894 Ricardo-1894 approved these changes

@Ziheng-Wang Ziheng-Wang Ziheng-Wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alldne @Ricardo-1894 @Ziheng-Wang