Backend/feature/measurement without event #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pring2020-cs-gy-9223-class into backend/fetaure/measuerment_without_event
alldne
reviewed
Apr 8, 2020
mercury/views/measurement.py
Outdated
| } | ||
|
|
||
| for d in dic: | ||
| if json_data.get(dic[d]) is None: |
There was a problem hiding this comment.
Optional: name suggestion for readability
key_map = {
"timestamp": "date",
"sensor_id": "sensor_id",
"value": "values",
}
for key, json_key in key_map.items():
if json_key not in json_data:
return Response(...)
res[key] = json_data[json_key]
There was a problem hiding this comment.
Nice suggestion! I have updated the code.
| @@ -12,12 +12,42 @@ def build_error(str): | |||
| return json.dumps({"error": str}) | |||
|
|
|||
|
|
|||
| def add_measurement(request, event): | |||
| json_data = request.data | |||
| if isinstance(json_data, str): | |||
There was a problem hiding this comment.
What if json_data is not str?
There was a problem hiding this comment.
It will be a JSON dict. The only case that the json_data is a string is that it is transferred through radio script since the native request module can only accept the string.
There was a problem hiding this comment.
Got it. Later it would be great to add assert for the input type (i.e either a JSON dict or a stringified json, otherwise fail loudly). But looks good to me at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the first event as the active event for end to end demo