Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend team #327

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Frontend team #327

merged 3 commits into from
Apr 9, 2020

Conversation

daisycrego
Copy link
Contributor

Corrections based on feedback from backend (@alldne)

Copy link
Contributor

@sunnybansal sunnybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alldne alldne self-requested a review April 9, 2020 15:38
@daisycrego daisycrego removed the request for review from alldne April 9, 2020 15:38
@alldne
Copy link
Contributor

alldne commented Apr 9, 2020

@daisycrego This branch is out-of-date with the base branch.

@alldne alldne requested review from alldne and removed request for alldne April 9, 2020 15:43
@daisycrego daisycrego merged commit d6c06a1 into master Apr 9, 2020
@alldne
Copy link
Contributor

alldne commented Apr 9, 2020

So it's accidentally merged into master without an approval from oncall. But anyway it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants