Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transfer dict to JSONField instead of str #336

Merged
merged 5 commits into from
Apr 9, 2020
Merged

transfer dict to JSONField instead of str #336

merged 5 commits into from
Apr 9, 2020

Conversation

VentusXu09
Copy link
Contributor

No description provided.

@VentusXu09 VentusXu09 requested a review from alldne April 9, 2020 17:53
alldne
alldne approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@alldne alldne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The code is getting a little bit error-prone but it's still acceptable for me. Let's improve it later.

alldne
alldne suggested changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@alldne alldne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is broken

@alldne alldne changed the base branch from master to backend/develop April 9, 2020 18:06
alldne
alldne approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@alldne alldne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VentusXu09 VentusXu09 merged commit d21b869 into backend/develop Apr 9, 2020
@VentusXu09 VentusXu09 mentioned this pull request Apr 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alldne alldne alldne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VentusXu09 @alldne