Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 and #26 UML added #67

Merged
merged 5 commits into from
Oct 4, 2022
Merged

#3 and #26 UML added #67

merged 5 commits into from
Oct 4, 2022

Conversation

yalexublue
Copy link
Contributor

Added 4 files, two pngs and two txt into the designated folder, please confirm the content and decide whether to merge

Copy link
Contributor

@waltage waltage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set up a .gitignore file that prevents files like .DS_Store from being committed

Copy link
Contributor

@waltage waltage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#26 Diagram

A few different options for this:

  1. Violation >=3 should move right; The user is not going to make the distinction, nor will the frontend, for how many violations have happened; in this case, is the intention that the API automatically deletes the account? Is the account deleted, or is the account suspended (can still view recommendations/share shortlists, just can't post to forum)?
  2. Admin initiates the request to delete based on some criteria (>=3 as it's here); in this instance, this should be a separate flow -- the admin will delete accounts for many different reasons beyond just violation >=3; As above, is the account suspended or actually deleted? What is the account suspended from? Can admins change suspension to different services, etc.

Copy link
Contributor

@waltage waltage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .DS_Store files, too :)

docs/.gitignore Show resolved Hide resolved
@yalexublue
Copy link
Contributor Author

#26 Diagram

A few different options for this:

  1. Violation >=3 should move right; The user is not going to make the distinction, nor will the frontend, for how many violations have happened; in this case, is the intention that the API automatically deletes the account? Is the account deleted, or is the account suspended (can still view recommendations/share shortlists, just can't post to forum)?
  2. Admin initiates the request to delete based on some criteria (>=3 as it's here); in this instance, this should be a separate flow -- the admin will delete accounts for many different reasons beyond just violation >=3; As above, is the account suspended or actually deleted? What is the account suspended from? Can admins change suspension to different services, etc.

I was thinking give the decision to the super user, so even more than three strikes there might be the case the normal user won't be banned, but I'm find to put it to right side, so to my understanding, if there are more than two violations. The backend will initiate delete. So the Admin is just view post and send out violation counts, would this work? Also I agree it's suspended instead of permanent delete, it would be suspended from gaining any services in front end. Feel free to make change though, I'll do my best give it a go

Copy link
Contributor

@waltage waltage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Pooja-Codes Pooja-Codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both require changes!

docs/design/#26-Admin-as-Superuser.txt Show resolved Hide resolved
docs/design/#26-Admin-as-Superuser.txt Show resolved Hide resolved
Admin->Frontend:Request to recover user account
Frontend->Backend:Confirm account recovery
Admin->Frontend:Modify user data
Frontend->Backend:Confirm data change and store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, missing reply message from backend-->frontend-->admin! How will the admin know if the data has been modified or not?

UI (Browser) -> User: Render Detailed View
API -> API: Cache School's Detailed Data
note over User,UI (Browser): Or, user discards/categorizes school?
User -> UI (Browser): TO CATEGORIZE EPIC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both diagrams' flow is clear! Great Work!

Copy link
Contributor

@Pooja-Codes Pooja-Codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!!

@@ -0,0 +1,11 @@
title #26 Admin as Superuser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are commits so we can refer previous-updated things. Discard backups! Otherwise All Perfect!!

Data Store -> API: Send Schools' Simplified Data
API --> UI (Browser): Send Selections (Simple View Dataset)
UI (Browser) --> User: Render Simple View
Data Store -> API: Confirm Stored Preferences
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a "status ok" message to the API? Should it go directly under "Store Preferences" (line 13)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's confirming there's no pending change to user preference also initiate API to start calculating user preference

UI (Browser) --> User: Render Simple View
Data Store -> API: Confirm Stored Preferences
API --> API: Compute first matches
API --> Data Store: Store match set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two lines meant to happen at the end of a user "session", like when they close the site? If so, maybe "compute next matches" instead of first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should happen as soon as we obtain a solid user preference settings. So we will be able to send out data fit user requirement


activate Frontend
Admin->Frontend:Check forum contents
note over Admin, Frontend: Chat violates regulations?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the discussion is b/w a child and its parent/guardian, I don't think we would need this anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it for now, I think forum is still to be considered, but should be moved into icebox

Copy link
Contributor

@jainsvaibhav jainsvaibhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if we can update otherwise let's keep it as it is.

@yalexublue yalexublue merged commit 3fb0451 into develop Oct 4, 2022
@yalexublue yalexublue deleted the #3#26-UML-YX branch October 4, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants