Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Dark Theme #17

Closed
lennartkoopmann opened this issue Apr 24, 2019 · 5 comments
Closed

Feature Request: Dark Theme #17

lennartkoopmann opened this issue Apr 24, 2019 · 5 comments
Assignees
Labels
feature request New feature or request please try it

Comments

@lennartkoopmann
Copy link

First of all, thank you so much for this great project.

My first feature request would be a dark theme. The fairly bright colors can be a little overwhelming in dark environments.

@gcla
Copy link
Owner

gcla commented Apr 24, 2019

Great idea, I'll do it :-)

@pocc pocc added the feature request New feature or request label May 9, 2019
@gcla gcla self-assigned this May 25, 2019
@gcla
Copy link
Owner

gcla commented Jun 7, 2019

Hi - I've pushed a new branch called "darkmode". Would you be willing to give it a try? You should be able to compile it up like this:

git clone https://github.com/gcla/termshark
cd termshark
git checkout origin/darkmode
export GO111MODULE=on
go install -ldflags="-X github.com/gcla/termshark.Version=1.0.0+" ./...

Then termshark will be in ~/go/bin/.

You can run it like this:

termshark ... --dark-mode

Or set it permanently in the "main" section of XDG_CONFIG_HOME/termshark.toml:

[main]
  dark-mode = true

You can also toggle it in the running application itself via the menu button.

I hope it looks okay when the terminal supports >= 256 colors (e.g. TERM=xterm-256color) or just 8 colors (e.g. TERM=xterm). Let me know how it looks, what UI elements you'd like altered, etc :-)

@kutsan
Copy link

kutsan commented Jun 7, 2019

I think dark theme should be default IMO.

@pocc
Copy link
Collaborator

pocc commented Jun 7, 2019

Verified working, Macos 10.14 via both command flag and menu item.

Screen Shot 2019-06-07 at 1 11 02 PM

@gcla
Copy link
Owner

gcla commented Jun 8, 2019

Hi @kutsan - I merged this back to master, and made the in-app toggle (via menu->d) persist the setting to the config file. So making dark-mode the persistent default can be done quickly without editing a config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request please try it
Projects
None yet
Development

No branches or pull requests

4 participants