Ascending order activity #172

RudraNilBasu · 2017-01-04T21:06:04Z

Ascending order activity

Given few randomly generated numbers, user will have to click on the numbers in
ascending order.

petitlapin

Hi,

I did remarks but there is a more global point to fix. The activity like that is not really interesting for children, It would be better to discuss it with the mailing list (there are teachers who can provide good advices on pedagogic values) to know how we can improve the quality of it.

Johnny

petitlapin · 2017-01-05T10:21:20Z

src/activities/ascending_order/ActivityInfo.qml

+  prerequisite: qsTr("Move a mouse and click on the correct place")
+  manual: qsTr("You are provided with few numbers. Click on the smallest number first, second smallest number second, and the largest number in the last")
+  credit: "openclipart.org"
+  section: qsTr("math")


we have an exception for this line, you don't need the qsTr() here.
It also misses the createdInVersion value (8000)

petitlapin · 2017-01-05T10:21:35Z

src/activities/ascending_order/Ascending_order.qml

+ */
+import QtQuick 2.1
+import GCompris 1.0
+import QtQuick.Window 2.0


do you need this?

petitlapin · 2017-01-05T10:22:08Z

src/activities/ascending_order/Ascending_order.qml

+            anchors {
+                horizontalCenter: parent.horizontalCenter
+            }
+            text: ""


no need to initialize the value with the default value

petitlapin · 2017-01-05T10:22:33Z

src/activities/ascending_order/Ascending_order.qml

+                property int scale_factor: Screen.pixelDensity/default_pix_density
+                Rectangle {
+                    property int imageX: 0
+                    width: 360/4 * ApplicationInfo.ratio


4 is the model size?

petitlapin · 2017-01-05T12:41:14Z

src/activities/ascending_order/Ascending_order.qml

+            Repeater {
+                id: boxes
+                model: 4
+                property int scale_factor: Screen.pixelDensity/default_pix_density


petitlapin · 2017-01-05T12:41:53Z

src/activities/ascending_order/ascending_order.js

+ * Copyright (C) 2016 Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>
+ *
+ * Authors:
+ *   Bruno Coudoin <bruno.coudoin@gcompris.net> (GTK+ version)


you can remove this line

petitlapin · 2017-01-21T10:27:21Z

src/activities/ascending_order/ascending_order.js

+}
+
+function printSorted() {
+    for(var i=0;i<entered.length-1;i++) {


I think there is a sort function in js directly

petitlapin · 2017-01-21T10:27:46Z

src/activities/ascending_order/ascending_order.js

+            }
+        }
+    }
+    for(i=0;i<entered.length;i++) {


you can use Array.join()

allon49 · 2017-02-13T20:11:07Z

Hi Rudra,

I had a look to your number ordering activity.
For me it is a very good idea.
Ordering activity is one of the most efficient activity to check if a kid has understood the decimal system (121 is bigger than 12 for example).
I tryed your activity and would like to suggest some improvments.

1- It should have a ok button for the kid to confirm when he is ready to validate.
2- Johnny found an application on the web which is exactly what I would like to see on gcompris. You can reproduce the behaviour using flow:

http://doc.qt.io/qt-4.8/qml-flow.html

3- There should be options like in the web application to match to different ages. You can have a look to divyam categorisation to see how he manages settings.

Good luck,

Emmanuel

Implemented draging and dropping of the blocks and shifting of the other blocks to it's correct position

Core changes are: * The size of the Blocks are now scaling with the change in screen size * the threshold distance changes with change in screen size * the tiles are now aligned in the center of the screen * the Rectangle containing the Flow resizes with change in screen size Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

Previously, we could change the position of a tile even when the tile (or some other tiles) are still animating, thus creating conflicts in position. This is corrected by not accepting any onPressed or onReleased signals while the animation is still going on Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

Changed the instruction of the activity. A possible bug was found when mouse input was taken into account even when the animation was still going on. This problem was reflected when the mouse was Released and the tile went to the previous location. This was solved by accepting the onPressed action only when the animation is over Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

Previously, the mouse input was checked with whether the animations are completed and whether the input is valid or not to determine whether or not the current mouse input should be taken into consideration. Here, instead of doing that, the mouseArea is enabled and disabled based on the value of the above two variables, which is also set via the script with the following rules: 1. It is valid when the level starts 2. It is not valid when the ok button is pressed 3. It is valid again when the answer turns out to be the wrong one This should be much more intuitive and bug free as far as working with the mouse is concerned Sigend-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

Added source of the icon on README (from openclipart) Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

Updated the manual of the ActivityInfo.qml Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

RudraNilBasu · 2017-02-27T20:50:41Z

@petitlapin @allon49 In the ascending order activity:

The items are moved by drag and drop to reposition the items
The tiles are now shifted for repositioning instead of swapping the positions
There is an ok button to allow the user to confirm when ready
There are 4 levels each with 3 sub levels, the sub levels are of the same difficulty (difficulty in the form
of number of tiles and the range of numbers)

petitlapin · 2017-02-28T21:09:44Z

Hi,
globally it's good (I have to take a closer look at the code).
Can you add the sublevel score (Score item in the core folder)?
Also, click on next/previous should change the level (and reset the current sublevel).
I would put the ok button above the bar too, else when resizing, they override

Thank you,

Johnny

petitlapin · 2017-02-28T21:02:02Z

src/activities/ascending_order/ActivityInfo.qml

+  difficulty: 2
+  icon: "ascending_order/ascending_order.svg"
+  author: "Rudra Nil Basu &lt;rudra.nil.basu.1996@gmail.com&gt;"
+  demo: false


this value should be true

petitlapin · 2017-02-28T21:03:24Z

src/activities/ascending_order/ActivityInfo.qml

+  demo: false
+  title: qsTr("Ascending Order")
+  description: qsTr("Arrange the given numbers in ascending order")
+  //intro: "click on the numbers in ascending order"


can you update this. It corresponds to the intro voice that should be listened to explain the activity.

petitlapin · 2017-02-28T21:04:03Z

src/activities/ascending_order/ActivityInfo.qml

+  goal: qsTr("arranging numbers in ascending order")
+  prerequisite: qsTr("Move, drag and drop using mouse")
+  manual: qsTr("You are provided with few numbers. Drag and Drop the numbers in it's correct position to reorder the numbers in ascending order")
+  credit: "openclipart.org"


I'm not sure it is needed, we used the images in a lot of places.

petitlapin · 2017-02-28T21:06:09Z

src/activities/ascending_order/Ascending_order.qml

+
+import "../../core"
+import "ascending_order.js" as Activity
+import "qrc:/gcompris/src/core/core.js" as Core


divyam3897 · 2017-03-01T15:34:45Z

hi,
I faced one more issue while playing it, for the extreme numbers (corner ones) if I drag a number beyond them then number came back and it was placed at the required position only if a portion of it overlapped with the corner number. Shouldn't the number be placed ahead of it (at its desired position) in that case?

Thank you
Divyam Madaan

RudraNilBasu · 2017-03-01T16:02:26Z

@divyam3897 hi, the numbers will change the position (and the others will shift back or front) only when one tile is placed over another tile (not exactly over, a minimum distance is maintained). In that case, the dragged number will occupy the position of the tile on which it was dragged and the rest of them will get shifted accordingly. So, if a tile is dragged to the extreme corner, it crosses the minimum distance and hence it comes back to the original position.

divyam3897 · 2017-03-01T16:18:57Z

I did a screenshot for some cases.

http://pasteboard.co/EehVhPRf2.png In this I was able to produce a gap between the numbers which should not be the case? (was not always reproducible but occured at times)
http://pasteboard.co/EejDEXNZv.png In this the tile (29 the one being dragged) is pretty close and maybe should not go back?

RudraNilBasu · 2017-03-01T16:55:41Z

@divyam3897

I didn't get the first case. Do the tiles remain in that way (separated by a space) after dropping a tile (after the mouse is released)? In that case is there any specific way by which it can be reproduced? Also, which number is being dragged in this case? Strange. This type of thing never actually occurred to me.
This one is okay. The 29 tile should be placed over the 74 tile in order to change the positions. The minimum distance is less in this case because had there been another tile on the left of 74, then the 29 tile should have occupied that position. The aim is to place a tile over the tile where it should belong.

allon49 · 2017-03-01T17:15:07Z

Hi, Divyam, did you do the screenshot while dragging? Emmanuel 2017-03-01 17:55 GMT+01:00 Rudra Nil Basu <notifications@github.com>:

…

@divyam3897 <https://github.com/divyam3897> 1. I didn't get the first case. Do the tiles remain in that way (separated by a space) after dropping a tile (after the mouse is released)? In that case is there any specific way by which it can be reproduced? Also, which number is being dragged in this case? Strange. This type of thing never actually occurred to me. 2. This one is okay. The 29 tile should be placed over the 74 tile in order to change the positions. The minimum distance is less in this case because had there been another tile on the left of 74, then the 29 tile should have occupied that position. The aim is to place a tile over the tile where it should belong. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#172 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHJUIOxRcGPzbbmqJUhxrWFeiGXCDJ6cks5rhaMNgaJpZM4LbEQo> .

Added sub level score, which will display the current sublevel in which the player is currently present. Level changes: Previously on changing the levels from the arrow key, the current sib level was getting incremented. As of now, on clicking the left or right arrow keys, the current sub level is reset to zero and the current level is decremented or incremented accordingly. On winning, the current sub level is incremented. The ok button is repositioned above the bar, so that it doesn't get overriden by the bar when resized Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

RudraNilBasu · 2017-03-01T18:00:24Z

@petitlapin Following changes were made:

demo is set to true
updated intro
Removed credit and unused imports
Added sub level score
Click on next/previous changes the level, while updating current sub level to zero
Repositioned ok button so that it doesn't get overridden by the bar.

divyam3897 · 2017-03-02T11:38:58Z

@allon49 yes, In one case the card returned back after the screenshot and in the other it stayed there, creating an empty place.
@RudraNilBasu The sublevel count also may need to be repositioned? It gets hidden in case of small screen size http://pasteboard.co/Ey6QDoCx7.png

The sub level score is moved to the top right corner of the screen just after the instruction text to avoid getting hidden under the bar when the screen size is reduced Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

RudraNilBasu · 2017-03-02T12:34:49Z

Repositioned the sub level score to avoid getting hidden under the bar for small screen sizes. The card coming back is normal, since it is not over any other card and it is going outside the play area once released, so the move is invalid and thus returns back to the original position. The card staying there is quite surprising. Does the problem still persist ? Strange, I can't seem to reproduce it in any way.

…

On Thu, 2 Mar 2017, divyam3897 wrote: @allon49 yes, In one case the card returned back after the screenshot and in the other it stayed there, creating an empty place. @RudraNilBasu The sublevel count also may need to be repositioned? It gets hidden in case of small screen size http://pasteboard.co/Ey6QDoCx7.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.[AMJ3zw7lt7uvGrmmgK9rVOnFRbHsvIPMks5rhqpTgaJpZM4LbEQo.gif]

petitlapin · 2017-03-07T11:51:16Z

src/activities/ascending_order/Ascending_order.qml

+            property alias flow: flow
+            property alias container: container
+            property real ratio: ApplicationInfo.ratio
+            property Score score: score


it should be an alias

petitlapin · 2017-03-07T11:51:29Z

src/activities/ascending_order/ActivityInfo.qml

+  demo: true
+  title: qsTr("Ascending Order")
+  description: qsTr("Arrange the given numbers in ascending order")
+//  intro: "arrange the numbers in ascending order by placing a number in it's correct position"


petitlapin · 2017-03-07T11:57:39Z

src/activities/ascending_order/ascending_order.js

+
+var currentLevel = 0
+var numberOfLevel = 4
+var currentSubLevel = 0


you can directly use score.currentSubLevel

petitlapin · 2017-03-07T11:57:52Z

src/activities/ascending_order/ascending_order.js

+var currentLevel = 0
+var numberOfLevel = 4
+var currentSubLevel = 0
+var numberOfSubLevel = 3


you can directly use score.numberOfSubLevels

petitlapin · 2017-03-08T09:35:35Z

src/activities/ascending_order/ascending_order.js

+
+var currentLevel = 0
+var numberOfLevel = 4
+var currentSubLevel = 0


you should directly use Score currentSubLevel instead and remove the items.score.message assignment below

petitlapin · 2017-03-08T10:09:27Z

src/activities/ascending_order/ascending_order.js

+
+var currentLevel = 0
+var numberOfLevel = 4
+var currentSubLevel = 0


you can directly use Score.currentSubLevel

petitlapin · 2017-03-08T15:29:08Z

src/activities/ascending_order/ascending_order.js

+
+var currentLevel = 0
+var numberOfLevel = 4
+var currentSubLevel = 0


you can directly use the score for this instead of having 2 other variables

Used sub level from score instead of creating new variables. Fixed typing error in ActivityInfo.qml and used alias for the score in QObject Signed-off-by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

Added arranging alphabetical order in it's ascending and descending order. Number of sub levels is increased to 4, each containing 2 ascending and 2 descending ordering sub-levels Signed-off-by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

RudraNilBasu · 2017-03-12T07:46:28Z

@petitlapin Following changes were made:

numberOfSublevels and currentSublevels are used from Score.qml instead of using extra variables.
Used alias in score in QtObject
Number of sublevels is increased to 4
Each sublevel contains 2 ascending and 2 descending order arrangements
Added alphabetical order arrangement

The copyright option was not properly filled previously. It is now corrected with proper name and email address Signed-off-by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

Previously, the alphabets activity only contained a-z english alphabets. Now, it allows translation for different languages An array is maintained to store [qsTr("a")....qsTr("z")] and a random value is chosen from the array and then placed in the block Signed-off-by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

All the letters are now stored in the letters string separated by "/". Few other fixes, including the problem with boxes not changing positions when released on a nearby box Signed-off-by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

RudraNilBasu · 2017-05-15T18:36:18Z

@petitlapin I have changed the alphabets activity to support various languages other than english.
Also, for testing purposes, I have tested it by replacing

var letters = qsTr("a/b/c/d..../z")

with

var letters = qsTr("À/à/Â/â/Æ/æ/Ç/ç/È/è/É/é/Ê/ê/Ë/ë/Î/î/Ï/ï/Ô/ô/Œ/œ/Ù/ù/Û/û/Ü/ü/«/»/€/₣")

petitlapin · 2017-05-16T15:29:27Z

src/activities/alphabetical_order/ActivityInfo.qml

+  icon: "alphabetical_order/alphabetical_order.svg"
+  author: "Rudra Nil Basu &lt;rudra.nil.basu.1996@gmail.com&gt;"
+  demo: true
+  title: "Alphabetical Order"


petitlapin · 2017-05-16T15:40:20Z

src/activities/alphabetical_order/ActivityInfo.qml

+  goal: qsTr("arranging alphabets in ascending or descending order as instructed")
+  prerequisite: qsTr("Move, drag and drop using mouse")
+  manual: qsTr("You are provided with few alphabets. Drag and Drop the alphabets in its correct position to reorder the numbers in ascending or descending order as instructed")
+  section: "math"


petitlapin · 2017-05-16T16:09:15Z

src/activities/alphabetical_order/Alphabetical_order.qml

@@ -0,0 +1,30 @@
+/* GCompris - alphabetical_order.qml
+ *
+ * Copyright (C) 2016 Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>


petitlapin · 2017-05-16T16:12:38Z

src/activities/ascending_order/ascending_order.js

+    }
+}
+
+function generateRandomNumbers() {


need to be renamed more generic

petitlapin · 2017-05-16T16:16:14Z

src/activities/alphabetical_order/Alphabetical_order.qml

+import "../../core"
+import "../ascending_order"
+
+Ascending_order {


camelCase (also for filename). Same for AlphabeticalOrder

petitlapin · 2017-05-16T16:17:56Z

src/activities/ascending_order/ascending_order.js

+}
+
+function initLevel() {
+    ascendingOrder = items.score.currentSubLevel % 2 == 0 ? true : false


to be checked on the mailing list (or at least with Emmanuel) but I wouldn't change every sublevel. It would not be efficient to understand the meaning behind ascending/descending order

petitlapin · 2017-05-16T16:21:13Z

src/activities/ascending_order/ascending_order.js

+
+    if (mode == "alphabets") {
+        //: list containing all the characters separated by a "/"
+        var letters = qsTr("a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z")


I think having a help button showing the order could be nice.

allon49 · 2017-05-17T15:00:28Z

there are many things to be sorted
I think we should have three activities called sorting
1- numerical sorting
2- alphabetical sorting
3- measures sorting
in numerical one I would see it presented like in categorisation activity offering different categories to sort
1- > 1 to 9
2- 1-99
3- 1-999
4- 1-99999
5- 1-999 999 999
that would be for increase order.
Same thing for decrease order.
In french teaching system the first one is aimed to <6 years old
the second one 6-7 years old
then 8-9 then 9-10 etc.
We would have the same for decreasing
In measures we would be ordering km dm cm etc
size, weight, etc
then in alphabetical order
1- single letter a b c
2- two letters ab ac bc bg
3- real words plane - planning - planification

petitlapin · 2017-05-19T10:01:22Z

@allon49 if we do like that, we need to think of other activities where it could be applied to (not for this PR but it could be in the improvements section). With one generic submenu, if we manage to load datasets easily, then we can think of having the difficulty for each category instead at activity level (which would not make sense on this case as the activity level is more global than only a 2 years old span).
For the real words, it would need a new specific dataset so for now, I guess it could be a future improvement.
The question is to know if we do a first version like the current one (so each level corresponds to a range and we have sublevels in it) or do we directly do the menu one (but it would need to be generic enough to be "easily" adapted to the activities that need it)?

petitlapin · 2018-01-16T20:51:08Z

Merged in ascending_order branch to continue the work

Ascending order activity

f6b21d7

petitlapin requested changes Jan 21, 2017

View reviewed changes

RudraNilBasu added 8 commits February 20, 2017 03:02

ascending_order: Drag and shift blocks

83de38e

Implemented draging and dropping of the blocks and shifting of the other blocks to it's correct position

ascending order: code clean up

f392059

Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

ascending order: README

7042a9b

Added source of the icon on README (from openclipart) Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

ascending order: Activity info

5c8a813

Updated the manual of the ActivityInfo.qml Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

petitlapin requested changes Feb 28, 2017

View reviewed changes

ascending_order: sub level score anchors

dd6fc44

The sub level score is moved to the top right corner of the screen just after the instruction text to avoid getting hidden under the bar when the screen size is reduced Signed-off by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

petitlapin requested changes Mar 8, 2017

View reviewed changes

RudraNilBasu added 2 commits March 11, 2017 16:27

ascending order: Use sub level from Score

b7c888f

Used sub level from score instead of creating new variables. Fixed typing error in ActivityInfo.qml and used alias for the score in QObject Signed-off-by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

ordering: Add alphabetical ordering

529e714

Added arranging alphabetical order in it's ascending and descending order. Number of sub levels is increased to 4, each containing 2 ascending and 2 descending ordering sub-levels Signed-off-by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

RudraNilBasu added 2 commits April 2, 2017 01:24

copyright: Added Copyright- alphabetical_order.qml

ae5c759

The copyright option was not properly filled previously. It is now corrected with proper name and email address Signed-off-by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

alphabets: Fix problem with qsTr() translation

0bec87a

All the letters are now stored in the letters string separated by "/". Few other fixes, including the problem with boxes not changing positions when released on a nearby box Signed-off-by: Rudra Nil Basu <rudra.nil.basu.1996@gmail.com>

petitlapin requested changes May 16, 2017

View reviewed changes

petitlapin closed this Jan 16, 2018

Ascending order activity #172

Ascending order activity #172

Conversation

RudraNilBasu commented Jan 4, 2017

petitlapin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allon49 commented Feb 13, 2017

RudraNilBasu commented Feb 27, 2017

petitlapin commented Feb 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

divyam3897 commented Mar 1, 2017

RudraNilBasu commented Mar 1, 2017

divyam3897 commented Mar 1, 2017

RudraNilBasu commented Mar 1, 2017

allon49 commented Mar 1, 2017 via email

RudraNilBasu commented Mar 1, 2017

divyam3897 commented Mar 2, 2017

RudraNilBasu commented Mar 2, 2017 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RudraNilBasu commented Mar 12, 2017

RudraNilBasu commented May 15, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allon49 commented May 17, 2017

petitlapin commented May 19, 2017

petitlapin commented Jan 16, 2018

RudraNilBasu commented May 15, 2017 •

edited

Loading