Upgrade e3nn to fix batch normalization runtime issue with final_conv module
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amorehead Have you encountered this e3nn bug while running DiffDock? |
|
Hello. I haven't tested to see if DiffDock-L's codebase now raises this error, but for DiffDock 1 it did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with version
0.5.1ofe3nn, the authors of the library are now guarding against attempting to aggregate scalar means if no scalar irreps are given as input: https://github.com/e3nn/e3nn/blob/bb71b3c75c38c6d633cfebe9988b1fb1563432c0/e3nn/nn/_batchnorm.py#L191(This PR also adds
wandbto the installation instructions for new Conda environments)It's possible version
0.5.0ofe3nnwas pinned accidentally, even though the source code will only run with0.5.1ofe3nn. I hope this helps!