Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GCOV JSON intermediate format #766

Merged
merged 38 commits into from
Aug 29, 2024

Conversation

Spacetown
Copy link
Member

@Spacetown Spacetown commented Apr 8, 2023

GCOV introduced a JSON intermediate format with version 9.1.
If the gcov help contains the option --json-format this option is used to get compressed JSON files (.gcov.json.gz) instead of the human readable files (.gcov). The compressed JSON files are only used if the calls are excluded (default) because the call information isn't present in the JSON format yet.

Closes #282

@Spacetown Spacetown added Type: Enhancement Gcov Internal change Internal change not visible to user labels Apr 8, 2023
@Spacetown Spacetown added this to the Upcoming release milestone Apr 8, 2023
@Spacetown Spacetown marked this pull request as draft April 9, 2023 06:14
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Attention: Patch coverage is 94.28571% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.68%. Comparing base (2a24953) to head (ccb4972).

Files Patch % Lines
gcovr/formats/gcov/read.py 93.87% 4 Missing and 2 partials ⚠️
gcovr/formats/html/write.py 90.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
- Coverage   94.73%   94.68%   -0.05%     
==========================================
  Files          50       50              
  Lines        3948     4043      +95     
  Branches      838      867      +29     
==========================================
+ Hits         3740     3828      +88     
- Misses        129      135       +6     
- Partials       79       80       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spacetown Spacetown force-pushed the read_gcov_json_format branch 2 times, most recently from f131ed7 to 0941f68 Compare April 12, 2023 20:11
gcovr/formats/gcov/read.py Outdated Show resolved Hide resolved
@Spacetown Spacetown removed this from the Upcoming release milestone May 20, 2023
@Spacetown Spacetown added this to the WishList milestone Dec 12, 2023
@Spacetown Spacetown requested a review from Pesa July 14, 2024 09:25
@Spacetown Spacetown modified the milestones: WishList, Upcoming release Jul 18, 2024
@Spacetown Spacetown marked this pull request as draft July 18, 2024 19:02
@Spacetown Spacetown marked this pull request as ready for review July 21, 2024 19:41
@Spacetown
Copy link
Member Author

@Pesa I would be happy if you could review the change so that we can close this PR after a long time.

Copy link

codacy-production bot commented Aug 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c31770b) 3878 3788 97.68%
Head commit (5a26df7) 3968 (+90) 3877 (+89) 97.71% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#766) 138 138 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Spacetown Spacetown merged commit 7925924 into gcovr:main Aug 29, 2024
35 checks passed
@Spacetown Spacetown deleted the read_gcov_json_format branch August 29, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gcov Internal change Internal change not visible to user Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GCOV intermediate format
3 participants