Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect excluded/noncode lines for aggregated branch coverage. #611

Merged
merged 3 commits into from
Apr 18, 2022

Conversation

Spacetown
Copy link
Member

Do not count excluded ore noncode lines for aggregated branch coverage as mentioned in #600.

@Spacetown Spacetown added this to the 5.2 milestone Apr 16, 2022
@Spacetown Spacetown requested a review from latk April 16, 2022 20:04
@Spacetown Spacetown force-pushed the respect_excluded_and_noncode_lines branch from 3a0faee to b4f1146 Compare April 16, 2022 20:04
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #611 (b4f1146) into master (08f360d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          24       24           
  Lines        3315     3317    +2     
  Branches      617      619    +2     
=======================================
+ Hits         3153     3155    +2     
  Misses         92       92           
  Partials       70       70           
Flag Coverage Δ
ubuntu-18.04 93.90% <100.00%> (+<0.01%) ⬆️
windows-2019 94.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/coverage.py 98.95% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f360d...b4f1146. Read the comment docs.

Copy link
Member

@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I haven't checked the changes to the reference files in detail, but the new output seems to be more correct.

@Spacetown Spacetown merged commit bdde94f into gcovr:master Apr 18, 2022
@Spacetown Spacetown deleted the respect_excluded_and_noncode_lines branch April 18, 2022 10:58
@Spacetown
Copy link
Member Author

I've dumped the data to check which branches aren't counted anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants