Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Drop support for Python < 2.6 #195
The code base needs to be compatible across a wide range of Python versions. But that can only go so far. The user guide mentions these supported versions:
It is also likely that some users are stuck on 2.6, so we shouldn't intentionally break 2.6 compatibility (at least not without a good reason).
But support of earlier versions has disproportianate cost and little value. This PR removes any code that is unreachable under 2.6 or later.
As an additional change, the unit tests now use decorators to annotate the test classes.
You could also add
python_requires to setup.py to help pip. For example, see: https://stackoverflow.com/a/44660547/724176
Also, it would be useful to add version classifiers to setup.py (https://pypi.python.org/pypi?%3Aaction=list_classifiers).
And there's a few other bits that can be removed:
(There's probably some old Python 3.x stuff that can go from there too, is only 3.4+ supported?)
Thank you @hugovk for these statistics – they demonstrate that this change will not hurt users.
And thank you too for the suggestions re classifiers and python_requires, I'll look into those shortly.
The remaining unneeded version checks are constrained to the vendored virtualenv scripts. This will be resolved by deleting the scripts completely in #190.