Make the library work well with RN 0.29+ on Android and add support for multiple event handlers and multiple sockets #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReadableNativeMap constructor is now protected. We have to override it with our own constructor if we want it to be usable in our package.
ReactPackage no longer includes a createJSModules function
Instead of emitting events with all the parameters packed into a single array, we spread them over multiple arguments. This is consistent with the way the javascript socketio client behaves when receiving events.
Socket.io-client v0.0.7 uses the OkHttp3 ws module which is deprecated by OkHttp3 since 3.5.0 because ws is now part of OkHttp3. On later versions of react native which include OkHttp3 > 3.5 this causes a multiple dex define error at build time
This JS socketio Socket class has a close method.
saalihou
changed the title
This was referenced Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed incompatible methods
Fixed dex multiple defines error due to old socketio java client version
Added support for multiple event handlers on the same event
Added support for path option in Android
Added support for multiple sockets on Android
I unfortunately do not have enough iOS/Swift knowledge to make checks on the iOS side (+ I do not own a MAC :D). If anyone is willing to look into it, otherwise I will have a colleague help me out on it soon.