Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doi button #677

Merged
merged 4 commits into from
Sep 15, 2018
Merged

Doi button #677

merged 4 commits into from
Sep 15, 2018

Conversation

andrewfowlie
Copy link
Contributor

Purpose

Implements #674

@gcushen
Copy link
Collaborator

gcushen commented Sep 13, 2018

Let's remove "DOI" from the language files and hard-code it as it's a global standard and trademarked name, so it shouldn't change between languages.

@gcushen gcushen added this to the v3 milestone Sep 13, 2018
@andrewfowlie
Copy link
Contributor Author

I will make the change, didn't realize that about DOI

@andrewfowlie
Copy link
Contributor Author

Alright, done, that makes things simpler!

@gcushen gcushen merged commit 02d84df into HugoBlox:master Sep 15, 2018
@gcushen
Copy link
Collaborator

gcushen commented Sep 15, 2018

Thanks @andrewfowlie !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v3
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewfowlie @gcushen