Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractHMM interface #18

Merged
merged 7 commits into from
Jul 9, 2023
Merged

AbstractHMM interface #18

merged 7 commits into from
Jul 9, 2023

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Jul 9, 2023

  • Replace the state and observation processes with a single AbstractHMM interface
  • Specify and test said interface with RequiredInterfaces.jl (not compatible with LTS, commented out for now)
  • Modify the concrete type HMM, which now has fields init, trans and dists
  • Rename sufficient stats in Baum-Welch
  • Add precompilation workload with PrecompileTools.jl
  • Lower Julia compat 1.7 -> 1.6

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage: 94.73% and project coverage change: +5.20 🎉

Comparison is base (5df07f3) 86.63% compared to head (416239a) 91.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   86.63%   91.84%   +5.20%     
==========================================
  Files          19       16       -3     
  Lines         479      429      -50     
==========================================
- Hits          415      394      -21     
+ Misses         64       35      -29     
Impacted Files Coverage Δ
ext/HiddenMarkovModelsHMMBaseExt.jl 50.00% <0.00%> (ø)
src/utils/fit.jl 76.92% <ø> (ø)
src/utils/lightdiagnormal.jl 100.00% <ø> (ø)
src/utils/check.jl 80.00% <85.71%> (+13.33%) ⬆️
src/abstract_hmm.jl 93.75% <93.75%> (ø)
src/hmm.jl 89.47% <93.75%> (+20.24%) ⬆️
src/HiddenMarkovModels.jl 85.71% <100.00%> (-14.29%) ⬇️
src/inference/forward_backward.jl 95.58% <100.00%> (ø)
src/inference/forward_backward_storage.jl 100.00% <100.00%> (ø)
src/inference/logdensity.jl 94.73% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gdalle gdalle merged commit 56e3b56 into main Jul 9, 2023
6 checks passed
@gdalle gdalle deleted the abstract_hmm branch July 9, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify rand(rng, dist) interface Get rid of StateProcess and ObservationProcess
1 participant