Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades all around #32

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Upgrades all around #32

merged 1 commit into from
Sep 5, 2023

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Sep 5, 2023

Breaking

  • Remove AbstractModel to make AbstractHiddenMarkovModel a subtype of AbstractMarkovChain

Features

  • New function forward
  • (Not working) chain rule for reverse mode autodiff of `logdensityof(hmm, obs_seq)

Improvements

  • Better docstrings
  • Precompile on parallel versions of inference algos to hit more code paths

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 85.00% and project coverage change: -2.18% ⚠️

Comparison is base (bca1bab) 93.16% compared to head (b2050fb) 90.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   93.16%   90.99%   -2.18%     
==========================================
  Files          19       18       -1     
  Lines         483      522      +39     
==========================================
+ Hits          450      475      +25     
- Misses         33       47      +14     
Files Changed Coverage Δ
src/inference/viterbi.jl 95.45% <ø> (ø)
src/types/abstract_hmm.jl 90.90% <ø> (ø)
ext/HiddenMarkovModelsChainRulesCoreExt.jl 13.33% <13.33%> (ø)
src/inference/forward.jl 92.15% <88.23%> (ø)
src/HiddenMarkovModels.jl 100.00% <100.00%> (ø)
src/inference/baum_welch.jl 90.69% <100.00%> (ø)
src/inference/forward_backward.jl 97.11% <100.00%> (+1.52%) ⬆️
src/types/abstract_mc.jl 97.29% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit c1f18c7 into main Sep 5, 2023
4 of 6 checks passed
@gdalle gdalle deleted the chain_rules branch September 10, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant