Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An attempt to work around a gopkg.in/module error in a dependency. #267

Merged
merged 1 commit into from Apr 8, 2019

Conversation

gcla
Copy link
Contributor

@gcla gcla commented Mar 24, 2019

Hi - I tried to update my work to use your latest version of tcell using the command below, and ran into a grungy go modules error. It looks like the go-colorful repo has fixed their references to go-sqlmock with this commit: lucasb-eyer/go-colorful@4de7d68. In my fork of tcell, updating go-colorful with

$ go get -u github.com/lucasb-eyer/go-colorful

seemed to resolve the issue.

Graham

$ go get -u -v github.com/gdamore/tcell
Fetching https://golang.org/x/text?go-get=1
Fetching https://gopkg.in/DATA-DOG/go-sqlmock.v1?go-get=1
Parsing meta tags from https://golang.org/x/text?go-get=1 (status code 200)
get "golang.org/x/text": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text?go-get=1
Parsing meta tags from https://gopkg.in/DATA-DOG/go-sqlmock.v1?go-get=1 (status code 200)
get "gopkg.in/DATA-DOG/go-sqlmock.v1": found meta tag get.metaImport{Prefix:"gopkg.in/DATA-DOG/go-sqlmock.v1", VCS:"git", RepoRoot:"https://gopkg.in/DATA-DOG/go-sqlmock.v1"} at https://gopkg.in/DATA-DOG/go-sqlmock.v1?go-get=1
go: finding github.com/lucasb-eyer/go-colorful latest
go: gopkg.in/DATA-DOG/go-sqlmock.v1@v1.3.3: go.mod has non-....v1 module path "github.com/DATA-DOG/go-sqlmock" at revision v1.3.3
go get: error loading module requirements

Specifically:

gcla@elgin:~/source/gowid$ go get -u -v github.com/gdamore/tcell
Fetching https://golang.org/x/text?go-get=1
Fetching https://gopkg.in/DATA-DOG/go-sqlmock.v1?go-get=1
Parsing meta tags from https://golang.org/x/text?go-get=1 (status code 200)
get "golang.org/x/text": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text?go-get=1
Parsing meta tags from https://gopkg.in/DATA-DOG/go-sqlmock.v1?go-get=1 (status code 200)
get "gopkg.in/DATA-DOG/go-sqlmock.v1": found meta tag get.metaImport{Prefix:"gopkg.in/DATA-DOG/go-sqlmock.v1", VCS:"git", RepoRoot:"https://gopkg.in/DATA-DOG/go-sqlmock.v1"} at https://gopkg.in/DATA-DOG/go-sqlmock.v1?go-get=1
go: finding github.com/lucasb-eyer/go-colorful latest
go: gopkg.in/DATA-DOG/go-sqlmock.v1@v1.3.3: go.mod has non-....v1 module path "github.com/DATA-DOG/go-sqlmock" at revision v1.3.3
go get: error loading module requirements
@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #267 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   19.58%   19.58%           
=======================================
  Files          17       17           
  Lines        1445     1445           
=======================================
  Hits          283      283           
  Misses       1146     1146           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec71b09...baa57b5. Read the comment docs.

@gdamore gdamore merged commit 8925703 into gdamore:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants