Add motion to EventMouse #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made this PR from my master branch, which was a bad idea, so I'm going to close this and re-open a new one. Sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes
EventMouseto also store whether or not the event was sent as a motion event. In the current version of tcell, the motion bit is just thrown away, but this can be useful information on systems which are more limited in mouse reporting and don't always report correctly.For example, on Elementary OS, the mouse button is always sent as
32when there is motion, even when mouse button 1 is not pressed. With this PR I can tell whether the key was actually pushed down or not by storing when the key was first pressed without motion and then registering the motion events.