Major refactor away from child_process and to worker-farm. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker-farm provides a cleaner abstraction around managing child processes, allowing us to call functions instead of manually passing messages. This api allows us to write less code, and the code that we do write is a bit cleaner. Sadly some of the tests were removed as part of this refactor, but coverage will be restored in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worker-farm provides a cleaner abstraction around managing child processes,
allowing us to call functions instead of manually passing messages. This api
allows us to write less code, and the code that we do write is a bit cleaner.
Sadly some of the tests were removed as part of this refactor, but coverage
will be restored in the future.