Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UglifyES options were never used when defined #42

Merged
merged 1 commit into from
Dec 8, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,10 @@ function processMessage(msgLocation, callback) {
const cacheKey = cache.createCacheKey(source + !!map, message.options);
// We do not check the cache here because we already determined that this asset yields a cache
// miss in the parent process.
const uglifier = message.options.uglifyES ? require('uglify-es') : require('uglify-js'); // eslint-disable-line global-require, max-len
const minifiedContent = minify(source, map, message.options.uglifyJS, uglifier);
const uglifyES = message.options.uglifyES;
const uglifyJS = message.options.uglifyJS;
const uglifier = uglifyES ? require('uglify-es') : require('uglify-js'); // eslint-disable-line global-require, max-len
const minifiedContent = minify(source, map, uglifyES || uglifyJS, uglifier);
cache.saveToCache(cacheKey, JSON.stringify({
source: minifiedContent.code,
map: minifiedContent.map,
Expand Down