Pretty syntax errors #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A developer on my team spent more time than needed debugging a SyntaxError that was the result of attempting to minify es6 code that snuck into node_modules/. I think that by providing additional context on the failed file, we can help people be more productive. This change uses babel-code-frame to generate an error message that includes a few lines above/below the encountered SyntaxError.
gdborton
force-pushed
the
pretty-syntax-errors
branch
from
356cb44
to
096b179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A developer on my team spent more time than needed debugging a SyntaxError
that was the result of attempting to minify es6 code that snuck into
node_modules/. I think that by providing additional context on the failed file,
we can help people be more productive.
This change uses babel-code-frame to generate an error message that includes a
few lines above/below the encountered SyntaxError.