Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize get_datafile #49

Open
jreamy opened this issue Jul 14, 2020 · 3 comments
Open

Parameterize get_datafile #49

jreamy opened this issue Jul 14, 2020 · 3 comments
Assignees
Labels
pkg:api api related activities prio:low status:confirmed Is a valid issue and will be moved forward soon. type:feature New feature

Comments

@jreamy
Copy link

jreamy commented Jul 14, 2020

As a developer I would like to have more control of the keyword arguments get_datafile uses in requests to download files. I have had issues downloading large files in the past and had to implement a custom get_request method to allow access to the stream parameter of requests.get.

@skasberger skasberger added status:confirmed Is a valid issue and will be moved forward soon. and removed status:confirmed Is a valid issue and will be moved forward soon. labels Jul 21, 2020
@skasberger
Copy link
Member

skasberger commented Jul 21, 2020

As for the next release the feature freeze is already done, I will do this soon after it. Will do that more generic, so all keyword arguments can be passed down to the requests calls.

  • Add **kwargs to requests.request function calls.
  • Change calls of get, delete, post etc. to one call of requests.request with passing the method and all kwargs.

@skasberger skasberger self-assigned this Jul 21, 2020
@skasberger skasberger added pkg:api api related activities prio:low status:confirmed Is a valid issue and will be moved forward soon. type:feature New feature labels Jul 21, 2020
@skasberger skasberger added this to the Later milestone Jul 21, 2020
@skasberger
Copy link
Member

This will be solved in #72.

@skasberger skasberger modified the milestones: Later, v0.5.0 Feb 17, 2021
@skasberger skasberger mentioned this issue Mar 14, 2021
35 tasks
johnbradley added a commit to Imageomics/dataverse-access that referenced this issue Sep 27, 2022
Replaces pyDataverse DataAccessApi.get_datafile call with
equivalent code that streams the response instead of fetching
the entire file into memory.
The StreamingDataAccessApi object can be removed once this
pyDataverse issue is resolved: gdcc/pyDataverse#49

Fixes #1
@pdurbin
Copy link
Member

pdurbin commented Mar 4, 2024

As discussed during the 2024-02-14 meeting of the pyDataverse working group, we are closing old milestones in favor of a new project board at https://github.com/orgs/gdcc/projects/1 and removing issues (like this one) from those old milestones. Please feel free to join the working group! You can find us at https://py.gdcc.io and https://dataverse.zulipchat.com/#narrow/stream/377090-python

@pdurbin pdurbin removed this from the v0.5.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:api api related activities prio:low status:confirmed Is a valid issue and will be moved forward soon. type:feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants