Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove curl dependency #88

Open
13 tasks
skasberger opened this issue Feb 15, 2021 · 2 comments
Open
13 tasks

Remove curl dependency #88

skasberger opened this issue Feb 15, 2021 · 2 comments
Assignees
Labels
pkg:api api related activities prio:high status:confirmed Is a valid issue and will be moved forward soon. type:feature New feature

Comments

@skasberger
Copy link
Member

Remove curl dependency from pyDataverse, which is coming from replace_datafile().

Prepare

  • Test out the issue
  • Request the problem at IQSS

Implementation

  • Write tests
  • Update replace_file()
  • Update Docs
    • Homepage
    • Requirements
  • Add to release notes
  • Update Docstrings
  • Run pytest
  • Run tox
  • Run pylint
  • Run mypy

Review

Follow-Ups

@skasberger skasberger added type:feature New feature pkg:api api related activities prio:high status:confirmed Is a valid issue and will be moved forward soon. labels Feb 15, 2021
@skasberger skasberger added this to the v0.4.0 milestone Feb 15, 2021
@skasberger skasberger self-assigned this Feb 15, 2021
@skasberger skasberger mentioned this issue Mar 14, 2021
35 tasks
@bpoldrack
Copy link

Would like to upvote this and mention that:

  1. As far as I can tell, it's not replace_datafile, but update_datafile_metadata.
  2. Not only does it cause this dependency, but it makes update_datafile_metadata a strange exception with respect to its return value, which is a CompletedProcess object. So, not only not a Response like everywhere else, but also not "The json string responded by the CURL request, converted to a dict()" as the docstring reads.

@pdurbin
Copy link
Member

pdurbin commented Feb 14, 2024

As discussed during the 2024-02-14 meeting of the pyDataverse working group, we are closing old milestones in favor of a new project board at https://github.com/orgs/gdcc/projects/1 and removing issues (like this one) from those old milestones. Please feel free to join the working group! You can find us at https://py.gdcc.io and https://dataverse.zulipchat.com/#narrow/stream/377090-python

@pdurbin pdurbin removed this from the v0.4.0 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:api api related activities prio:high status:confirmed Is a valid issue and will be moved forward soon. type:feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants