Jakarta EE 10 and Java 17 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for breaking changes like Jakarta EE 9 updates etc.
The multipart feature never worked for real in the first place. The used library to support RFC2387 (multipart/related), Apache Commons Fileupload, was written to support RFC1867 (multipart/form-data). Thus, the support was broken and Dataverse never enabled it. This commit removes the commons-fileupload dependency and replaces the parsing of the Content-Disposition header for the filename with the Jersey header parser. This is necessary as the library is not compatible with Jakarta EE (v2.0 with Jakarta support was never released). See-also: https://www.mail-archive.com/sword-app-tech@lists.sourceforge.net/msg00327.html See-also: https://github.com/IQSS/dataverse/blob/c5d1df209aa960651a53cc67f456449a6f7158e0/src/main/java/edu/harvard/iq/dataverse/api/datadeposit/CollectionDepositManagerImpl.java#L171-L177
… to Maven central
pdurbin
commented
Aug 21, 2023
1 task
poikilotherm
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
After removing the Jakarta branch from the Github Action this PR is good to go!
Thanks @pdurbin !
Co-authored-by: Oliver Bertuch <poikilotherm@users.noreply.github.com>
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an upgrade to Jakarta EE 10 (including the javax -> jakarta namespace change) and Java 17.
Related Dataverse issue: