Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set volume to value between 0 and 1 #98

Merged
merged 7 commits into from
Nov 18, 2023
Merged

Conversation

gdelataillade
Copy link
Owner

 If left unspecified or set to `null`, the current system volume at the time of the alarm will be used.
 Defaults to `null`.

This feature will be added in alarm 3.0.0 because it includes breaking changes.

@gdelataillade gdelataillade self-assigned this Sep 27, 2023
@gdelataillade gdelataillade linked an issue Sep 27, 2023 that may be closed by this pull request
@jhonatan-3a
Copy link

this one really cool, any updates on this one ?

@gdelataillade
Copy link
Owner Author

Hey @jhonatan-3a

This feature will be added soon. If you need it right now you can import the branch directly to your project like explained here:
https://stackoverflow.com/a/54689403

@jhonatan-3a
Copy link

hey thank you for the feature, i can wait

@ProfessorX737
Copy link

Thanks for this. can merge pls?

@ProfessorX737
Copy link

I'm getting this error when I try building ios using this branch:

image

@ProfessorX737
Copy link

ProfessorX737 commented Nov 6, 2023

FYI I've renamed this this to 'systemVolume' and added another volume type 'audioVolume' in my fork of your repo if you want to update yours with it somehow? #107
Just bc I need it in my project

@gdelataillade
Copy link
Owner Author

Hi @ProfessorX737

I'm currently working hard on PR #105

I'll merge this PR as soon as I finish working on #105 because it involves breaking changes. Please be patient and in the meantime you can use the reference of this PR in your project. I'll keep you updated.

@gdelataillade gdelataillade merged commit 7709568 into main Nov 18, 2023
1 check passed
@gdelataillade
Copy link
Owner Author

@ProfessorX737 thanks for your help ! I finally found the time to merge this PR. I'm publishing a version 3.0.0-dev.1 of the package to deeply test this feature and others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exchange <bool>volumeMax with <double>forcedVolume
3 participants