Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all methods S3-methods for easier integration with other packages like disk.frame #8

Closed
xiaodaigh opened this issue Nov 30, 2019 · 2 comments

Comments

@xiaodaigh
Copy link

I want to integrate maditr with disk.frame but for that I need the methods in maditr to be S3 compatible. E.g.

let = function(data, ....) {
  UseMethod("let")
}

let.default = function(data, # omitted) {
  # your original let function implementation here; omitted
}

then in disk.frame I can implement the let method

let.disk.frame <- function(data,...) {
  # implement it for disk.frame
}

which will enable large datasets that doesn't fit into ram to benefit from maditr.

@gdemin
Copy link
Owner

gdemin commented Nov 30, 2019

Ok, will be added in the next release.

gdemin added a commit that referenced this issue Nov 30, 2019
…hanged because they are just alias to 'let' and 'take'.
@gdemin
Copy link
Owner

gdemin commented Dec 3, 2019

Added in version 0.6.3

@gdemin gdemin closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants