Firebase App Invite integration #668

tasomaniac · 2016-09-22T22:28:30Z

First of all, this turned out bigger than I expected. Sorry for that. 🙏

This PR adds new Firebase Invites API. Firebase Invites uses Dynamic Links internally which is where the magic occurs.

App Invite, on top of that, a UI where you can choose your friends to share. But it only includes sharing via SMS and Email. I really didn't like it. I think it is too restrictive.

Instead, I create dynamic links directly. Which then, user can choose whatever app they want to share.

I'm using https://gdg.events/invite/?sender=gplusid as link structure. This link will be opened if it is clicked in a computer.

If the app is already installed, it just opens the app.

If not, it installs the app and then in the login page, I put the picture and a welcome message there.
Since we have more info there now, I quickly add landscape version of the page.

Screenshots

Portrait	Landscape

Fixes #637

Had to remove home gdg on the server. It is not really used and causing problems now.

- Invite button is added to NavDrawer that just creates a dynamic url. - AppInvite related code from MainActivity is removed because it will be forwarded to AppInviteDeepLinkActivity by default using the deeplink.

The first page will be the welcome invite page. When we don't have invite, it will move on to the next page.

And windowBackground is set through themes

and remove old AppInviteDeepLinkActivity

Revert the changes in PlusUtils Upgrade play services

Move intent filters from MainActivity to StartActivity

friedger

nice

friedger · 2016-09-23T07:26:07Z

app/build.gradle

@@ -136,10 +136,11 @@ dependencies {
    compile "com.android.support.test.espresso:espresso-idling-resource:$rootProject.espressoVersion"

    //Play Services
+    compile "com.google.android.gms:play-services-auth:$rootProject.playServicesVersion"


Why do you need auth? It is not mentioned in the firebase integration documentation?

The piece of code that we have in Settings it's not working anymore. The class was removed. I first deleted that and realized that I can just add this dependency. The reason was the upgrade of the gms version.

friedger · 2016-09-23T07:29:10Z

app/src/main/java/org/gdg/frisbee/android/about/AboutActivity.java

+    private void shareAppInviteLink() {
+        AppInviteLinkGenerator linkGenerator = AppInviteLinkGenerator.create();
+        String gplusId = PlusUtils.getCurrentPersonId(getGoogleApiClient());
+        HttpUrl appInviteLink = gplusId != null


AboutActivity should not decide on how to handle not signed users. This should go into the linkGenerator.

friedger · 2016-09-23T07:33:13Z

app/src/main/java/org/gdg/frisbee/android/common/GdgNavDrawerActivity.java

@@ -303,6 +312,19 @@ private void navigateTo(Class<? extends GdgActivity> activityClass, Bundle addit
        mDrawerLayout.closeDrawers();
    }

+    private void shareAppInviteLink() {


Duplicate code, same as in AboutActivity

friedger · 2016-09-23T07:36:58Z

app/src/main/java/org/gdg/frisbee/android/onboarding/FirstStartStep2Fragment.java

+    @Override
+    public void onSaveInstanceState(Bundle outState) {
+        super.onSaveInstanceState(outState);
+        outState.putString(INVITE_SENDER,  inviteSender);


friedger · 2016-09-23T07:39:29Z

app/src/main/java/org/gdg/frisbee/android/onboarding/FirstStartStep2Fragment.java

+            .getPerson(inviteSender)
+            .enqueue(new Callback<Person>() {
+                @Override
+                public void success(Person sender) {


If we fail to load the sender then the invitation process stops here. We should still show the inviteContainer with a dummy image and a dummy name ("a friend" or so)

Totally makes sense. We should do it.

friedger · 2016-09-23T07:42:45Z

app/src/main/res/values/strings.xml

  <string name="invitation_error_message">App Invite was unsuccessful.</string>
  <string name="thanks_for_feedback">Thank you for your Feedback!</string>
  <string name="retry">Retry</string>
  <string name="title_event_series_greetings">New events coming up!</string>
  <string name="event_series_greetings">Learn more about %1$s and see events around the world!</string>
+  <string name="cd_invitation_sender_profile_image">Invitation sender profile image</string>


Did you upload the new strings to crowdin?

Strings are already upload/updated in crowdin.

Show empty invite UI if we have the invite but the sender is not found

tasomaniac · 2016-09-23T18:22:08Z

@friedger comments are addressed. 👍

friedger · 2016-09-23T20:31:46Z

app/src/main/java/org/gdg/frisbee/android/onboarding/Invite.java

+import android.os.Parcel;
+import android.os.Parcelable;
+
+class Invite implements Parcelable {


Why do you add this class? Is this "just" for giving String a meaning? Then sender should be gplusIdOfSender or so

tasomaniac · 2016-09-24T10:04:13Z

I did that to both provide a meaningful name and to handle 3 cases in 1
object.
String is not enough. We have 3 states.
No invite, invite without sender, invite with sender.

On Fri, Sep 23, 2016, 22:31 Friedger Müffke notifications@github.com
wrote:

@friedger commented on this pull request.

In app/src/main/java/org/gdg/frisbee/android/onboarding/Invite.java
#668 (review):

@@ -0,0 +1,38 @@
+package org.gdg.frisbee.android.onboarding;
+
+import android.os.Parcel;
+import android.os.Parcelable;
+
+class Invite implements Parcelable {

Why do you add this class? Is this "just" for giving String a meaning?
Then sender should be gplusIdOfSender or so

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#668 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAulyyAT2gqBBxq7Harj7Df-U354sXfLks5qtDcygaJpZM4KEbdH
.

tasomaniac added 17 commits September 22, 2016 22:00

Update play services

dfabbb7

Had to remove home gdg on the server. It is not really used and causing problems now.

Move app invite Activity to invite package

a281f08

Update strings

23836eb

Add invite to nav drawer

65afb13

App Invite update

b23fe7d

- Invite button is added to NavDrawer that just creates a dynamic url. - AppInvite related code from MainActivity is removed because it will be forwarded to AppInviteDeepLinkActivity by default using the deeplink.

Remove googly_bar

39a7953

Move AppInvite handling to FirstStartActivity

155da48

Increase the number of pages int the on boarding.

1c2a7a7

The first page will be the welcome invite page. When we don't have invite, it will move on to the next page.

Removed 1 layer of hierarchy

ee1dd2e

And windowBackground is set through themes

Remove FirstStartInvite page and put it into page 2 = login 

9eda6d1

Final portrait design of the app invite

700f8a0

Added landscape layout for login

0c23f36

Refine AppInviteLinkGenerator

86b584d

and remove old AppInviteDeepLinkActivity

Translations are updated

b5befc9

Include auth dependency and put the code in settings back in place

64e3617

Move AppInviteLinkGenerator

897975c

Revert the changes in PlusUtils Upgrade play services

Update app invite sharing in About screen as well

f173784

tasomaniac mentioned this pull request Sep 22, 2016

Firebase Dynamic Links for Event Share #669

Open

tasomaniac added this to the Release 2.6 milestone Sep 22, 2016

tasomaniac added 3 commits September 23, 2016 01:07

Put a default (shorter) url for non-logged in users.

6d1224c

Remove invite path from the link

85c85cb

Instead of catching all gdg.events links, just catch the main link.

0e2118c

Move intent filters from MainActivity to StartActivity

friedger suggested changes Sep 23, 2016

View reviewed changes

tasomaniac added 6 commits September 23, 2016 19:25

Merge remote-tracking branch 'origin/develop' into move/app_invite

1e25305

Remove unused field in Settings

0592fc1

Introduce an Invite class to hold the invite.

e335d0c

Show empty invite UI if we have the invite but the sender is not found

Show unknown UI if the loading of the sender fails

9f86b6d

Downgradle play services

28a8dc7

Move the duplicated code into AppInviteLinkGenerator

74cbb3a

Added new strings 

e60416d

friedger approved these changes Sep 23, 2016

View reviewed changes

friedger reviewed Sep 23, 2016

View reviewed changes

friedger merged commit e835045 into develop Sep 23, 2016

friedger deleted the move/app_invite branch September 23, 2016 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Firebase App Invite integration #668

Firebase App Invite integration #668

tasomaniac commented Sep 22, 2016 •

edited

Loading

friedger left a comment

friedger Sep 23, 2016

tasomaniac Sep 23, 2016

friedger Sep 23, 2016 •

edited

Loading

friedger Sep 23, 2016

friedger Sep 23, 2016

friedger Sep 23, 2016

tasomaniac Sep 23, 2016

friedger Sep 23, 2016

tasomaniac Sep 23, 2016

tasomaniac commented Sep 23, 2016

friedger Sep 23, 2016

tasomaniac commented Sep 24, 2016

@friedger commented on this pull request.

Firebase App Invite integration #668

Firebase App Invite integration #668

Conversation

tasomaniac commented Sep 22, 2016 • edited Loading

Screenshots

friedger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

friedger Sep 23, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tasomaniac commented Sep 23, 2016

Choose a reason for hiding this comment

tasomaniac commented Sep 24, 2016

@friedger commented on this pull request.

tasomaniac commented Sep 22, 2016 •

edited

Loading

friedger Sep 23, 2016 •

edited

Loading