for #525 Replace Logo with New Design #716
Conversation
added - font of google product sans
replaced drawer icon of home by vector drawable
| @@ -110,7 +110,7 @@ public void onClick(View view) { | |||
| } | |||
|
|
|||
| private void populateMainGroup(Menu menu) { | |||
| menu.add(GROUP_ID, DRAWER_HOME, Menu.NONE, R.string.home_gdg).setIcon(R.drawable.ic_drawer_home_gdg); | |||
There was a problem hiding this comment.
Thanks for the great pr :) Finally we have the new icons.
I was thinking I if this old png is used anywhere else or not. If not we should remove it.
Also do you think that this vector will work on older devices? Would be good to provide Screenshots in the description of the pr
There was a problem hiding this comment.
Tested on Emulator w/ API level 16.
Checked no other usage of old image, removed in next commit.
update - project now targets Android Studio 2.3
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.2.1-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.4-all.zip |
There was a problem hiding this comment.
I would prefer to keep dependency updates in separate PRs but it is fine.
I want to merge the PR but there is a bug fix release 3.4.1, can you update it?
| @@ -61,7 +61,7 @@ ext { | |||
| buildToolsVersion = '25.0.2' | |||
|
|
|||
| // App dependencies | |||
| supportLibraryVersion = '25.1.0' | |||
| supportLibraryVersion = '25.2.0' | |||
There was a problem hiding this comment.
Is support lib version upgrade related to vectors?
Should we even upgrade to later version 25.3.1?
There was a problem hiding this comment.
Not related.
But let me build with 25.3.1 and test.
|
Considering that the PR was open already for several days, merging it now. My comments are not that important. |
for #525
New GDG Icon for Launcher
Added Font Google Product Sans