Hero block #262
Merged
Hero block #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # bower.json # src/hoverboard-app.html # src/redux-store.html
sophieH29
reviewed
Jun 24, 2017
scripts/redux/reducer.js
Outdated
| switch (action.type) { | ||
| case TOGGLE_DRAWER: | ||
| return Object.assign({}, state, { | ||
| isDrawerOpened: action.value !== null ? action.value : !state.ui.isDrawerOpened |
There was a problem hiding this comment.
action.value ? action.value : !state.ui.isDrawerOpened
There was a problem hiding this comment.
Or even better action.value || !state.ui.isDrawerOpened
| } | ||
|
|
||
| app-header iron-pages { | ||
| z-index: 0; |
There was a problem hiding this comment.
why do you need this property?
sophieH29
approved these changes
Jun 25, 2017
CmoaToto
pushed a commit
to paug/android-makers-2019
that referenced
this pull request
Dec 24, 2018
* Add initial code for hero block * Add hero reducer * Remove .vscode settings * Add .vscode folder to .gitignore * Replace bower and npm with yarn for travis * Fix route reducer * Update header * Add hero reducer * Update hero * Add support of gradient for hero background. Make adaptive height of a hero * Add missing files to previous commit * Try to fix travis build * One more try on travis * Add one more try * Fix uiReducer. Update header layout on hero change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.