-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x should't close pinned tabs #1073
Comments
No this is not a bug:
Up to now, if you press I admit this feature is not enough, so I'll add a parameter named |
Thanks, that would be very useful
…On Monday, January 15, 2024, Dahan Gong ***@***.***> wrote:
No this is not a bug:
- on Chrome, Ctrl+W may close a pinned tab
- there should be at least one way to use Vimium C's shortcut to close
a pinned tab
Up to now, if you press Num + X (like 3x) to close num tabs, and the
current tab is not pinned or near to a pinned, then Vimium C will only
close non-pinned tabs.
I admit this feature is not enough, so I'll add a parameter named noPinned
to always prevent removeTab from removing any pinned tab.
—
Reply to this email directly, view it on GitHub
<#1073 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACG2GHFDSGMNQBP5X2EXFFTYOV3JFAVCNFSM6AAAAABBTNNAMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGY2DKOJQGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@gdh1995 Hi, I need noPinned feature, is there any nightly build with this feature?
|
拉了最新的源码,按说明编译了一下,安装在Vivaldi浏览器中,noPinned参数似乎无效,无论设置为true还是false,按x键,pinned标签页面始终会被关掉。 |
Sorry, has this been added to vimium? Firefox version thanks |
@g-i-o-r-g-i-o Sorry Vimium C v1 is in archive mode and won't be upgraded unless there's any security bug found, while Vimium v2 is still in development - recently, a bit slow - and may be released in the end of 2024. |
@gdh1995 能用了,谢谢! |
Describe the bug
"x", when used on pinned tabs, should not close the tab, since ctrl+w doesn't close the tab
To Reproduce
Steps to reproduce the behavior:
go to a pinned tab
press x
x closes the tab, while it shouldn't close it: it should probably just do nothing
Browser, OS and Vimium C versions
The text was updated successfully, but these errors were encountered: