Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display issues on Chromium-Edge in Windows High Contrast Mode #191

Closed
gdh1995 opened this issue Jun 27, 2020 · 8 comments
Closed

Display issues on Chromium-Edge in Windows High Contrast Mode #191

gdh1995 opened this issue Jun 27, 2020 · 8 comments
Labels

Comments

@gdh1995
Copy link
Owner

gdh1995 commented Jun 27, 2020

(issue on philc/vimium#3604)
Hello,

When Windows HCM is enabled (PrtSc+LAlt+LShift) on Chromium-Edge (Version 83.0.478.54), vimium doesn't render its elements properly such as 'open link' (f,F) or the help menu (?)

vimiumC
vimiumC2

@BlackenedPies Could you try this version ?
vimium_c-1.83.4-edge-b6c3a35.zip

If it works, then you will see white-on-black hint markers, and a readable help dialog, like:
Snipaste_2020-06-28_02-17-44

@BlackenedPies
Copy link

BlackenedPies commented Jun 27, 2020

The issue is with the 'text' color setting. When I select the preset for 'High Contrast Black' (like you're using), it works, but as soon as the text color is changed to any other color, it breaks. Is it possible to force it to a different color?

Also, in Chrome, vimium sometimes uses a yellow-white color scheme that's difficult to read. This appears to be caused by the extension 'Darken' along with the #enable-force-dark flag. Is it possible to force a default color scheme such as brown-yellow?

Capture

Capture

@gdh1995
Copy link
Owner Author

gdh1995 commented Jun 27, 2020

Thanks. I'll test the new color scheme in days.

As for Chrome, the #enable-force-dark is indeed annoying, and up to now I haven't found a way to change the "white" text color.

Here's a work-around: we can change the background color so that the text can be easier to read. You need to add css to “Custom CSS for Vimium C UI”:

.LH { background: green; }
.LH { border: 0.5px solid lightgreen; }

This idea is from another user (#111 (comment))

Added: I've added it into the Wiki: https://github.com/gdh1995/vimium-c/wiki/Style-the-UI-of-Vimium-C-using-Custom-CSS#work-with-enable-force-dark

@gdh1995
Copy link
Owner Author

gdh1995 commented Jun 27, 2020

Then this version should work: vimium_c-1.83.4-edge-c7c6bf9.zip

Vimium C v1.84.0 has been published on Edge.

gdh1995 added a commit that referenced this issue Jun 27, 2020
@gdh1995 gdh1995 added the bug label Jun 29, 2020
@Koolstr
Copy link

Koolstr commented Jul 6, 2020

Thank you for adding the workaround to the documentation, and for crediting me on it. :)
I hope it can save others some frustration and time going forward.

@gdh1995
Copy link
Owner Author

gdh1995 commented Jul 6, 2020

@BlackenedPies Vimium C v1.84.0 has been published on Edge and you may take a try.

@BlackenedPies
Copy link

Thanks!!! Edge works!

Could you clarify the usage of how the code should be placed within 'CSS for Vimium UI'? I was unable to change the appearance of the Chrome hint boxes with it

.LH { background: green; }
.LH { border: 0.5px solid lightgreen; }

@gdh1995
Copy link
Owner Author

gdh1995 commented Jul 6, 2020

On v1.84.0 it should work in normal mode (neither high contrast nor #enable-force-dark), so what's your detailed situation?

BTW, v1.83.4 has a bug affecting custom CSS, and please refer #152 (comment).

@BlackenedPies
Copy link

My mistake - I was using 'Vimium' on Chrome and not Vimium C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants