Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom possition for LinkHints activateModeWithQueue and activateModeToOpenInNewTab #208

Closed
pointtonull opened this issue Aug 16, 2020 · 10 comments

Comments

@pointtonull
Copy link

pointtonull commented Aug 16, 2020

Thanks a lot for your amazing plugin. Combined with keynav, makes it possible for me to use a computer.

(LinkHints.activateModeWithQueue) is my favorite feature, it makes browsing a pleasure.

I only wish it would honor browser setting on where to put the new tabs. Or, alternatively, it would be great if it had a setting option to choose vimium-c's behavior.

i.e.:

  • vimium-c behavior: tabs are open next to the current one, left to previously open related tabs
  • my browser default behavior: new tab open at the end, right of any other tab
  • firefox's default: new tab open after previously open related tabs

Do you think it's a worthy feature?

Edited 16/08/2020 to better explain the problem.

@gdh1995
Copy link
Owner

gdh1995 commented Aug 16, 2020

map t createTab position="end"

@pointtonull pointtonull changed the title Honor new_tab browser behaviour Custom possition for LinkHints activateModeWithQueue and activateModeToOpenInNewTab Aug 16, 2020
@pointtonull
Copy link
Author

map t createTab position="end"

Thanks for your promptly reply. I understand this mapping would allow to create a new empty tab at the end. But this is not what I was looking for.

I was talking about being able to customize where to open new tab with (Link Hints with Queue), or with (Link Hints to New Tab).

Is there a way to do it? (I could not find any in the documentation or in source code)

@gdh1995
Copy link
Owner

gdh1995 commented Aug 17, 2020

Um, seems not exist. Maybe I'll add this feature in this month or the next one.

@pointtonull
Copy link
Author

Thanks, you are very kind.

@gdh1995
Copy link
Owner

gdh1995 commented Aug 18, 2020

Please test this: vimium_c-1.84.3-firefox-1cf32a5.zip.

@pointtonull
Copy link
Author

pointtonull commented Aug 18, 2020

I tested several settings using Firefox 79.0 (64-bit) / Linux AMD64

All of these are working perfectly:

  • ✔️ map t LinkHints.activateModeWithQueue
  • ✔️ map t LinkHints.activateModeWithQueue position="start"
  • ✔️ map t LinkHints.activateModeWithQueue position="begin"
  • ✔️ map t LinkHints.activateModeWithQueue position="before"
  • ✔️ map t LinkHints.activateModeWithQueue position="after"

These are not working:

  • map t LinkHints.activateModeWithQueue position="end"
  • map t LinkHints.activateModeWithQueue position="default"

Both of them produce this error in the console:

Unchecked lastError value: Error: isPlaying is not defined 2 background.js:365
    <anonymous> moz-extension://cca877b4-6284-46f4-a686-8cfe0201d2c0/background.js:365

@gdh1995
Copy link
Owner

gdh1995 commented Aug 19, 2020

The old package contains a typo, so please try this: vimium_c-1.84.3-firefox-1cf32a5-fix.zip

BTW, the line of console output is not Vimium C's.

@pointtonull
Copy link
Author

pointtonull commented Aug 19, 2020

It's working perfectly now.
Thank you very much 🥧

@gdh1995
Copy link
Owner

gdh1995 commented Aug 23, 2020

Hello, the v1.85.0 has been released on Firefox Add-ons, and you may take a try.

@pointtonull
Copy link
Author

Confirmed, I had switch to the released version and it's working as expected.
Thank you very much

@gdh1995 gdh1995 closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants