Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling before content has loaded will go too far #45

Closed
meluskyc opened this issue Jun 6, 2019 · 3 comments
Closed

Scrolling before content has loaded will go too far #45

meluskyc opened this issue Jun 6, 2019 · 3 comments
Labels
bug

Comments

@meluskyc
Copy link

meluskyc commented Jun 6, 2019 •
edited
Loading

Using scrollPageDown before a page has fully loaded will scroll too far.

Vimium C Scroll Bug

Hopefully this is possible to fix. Vimium does not have this issue currently.
@gdh1995
Copy link
Owner

gdh1995 commented Jun 9, 2019

Confirm. Thanks, and the solution is in development.

gdh1995 added a commit that referenced this issue Jun 9, 2019
@gdh1995
fix a bug that VScroller may not receive keyup
0fc6c73 
If a page is loading, then keyboard events may be delayed,
and then keydown & keyup events will be dispatched without any interval.
In this case (like reddit.com), VScroller would continue to scroll
  unitl it consumed all .keyIsDown_.

This is for #45 .
@gdh1995
Copy link
Owner

gdh1995 commented Jun 17, 2019

Vimium C v1.75.7 has been published on Chrome Web Store, and you may have a try.

@meluskyc
Copy link
Author

Fixed. Thank you!

@gdh1995 gdh1995 added the bug label Mar 4, 2020
@ntriisii ntriisii mentioned this issue Jul 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gdh1995 @meluskyc