Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in Hangul #554

Open
demokritos opened this issue Feb 12, 2022 · 2 comments
Open

Search in Hangul #554

demokritos opened this issue Feb 12, 2022 · 2 comments

Comments

@demokritos
Copy link

Describe the bug

When inputting Hangul in search('/' command), every key committing a Hangul
syllable is eaten if that word is matched. For example, say the page contains a
Hangul word, "한글두글", and you want to search "한글사랑". In inputting
'한글사랑', 'ㄱ' keystroke will be eaten since '한' is committed by that
keystroke and is matched with '한' of "한글두글" in the page. So you have to
input 'ㄱ' again. Now you complete '글' and type 'ㅅ', but 'ㅅ' is also eaten
because '한글' is matched. Afterward, no keys are eaten.
This exact phenomenon appears under my circumstance using unpopular input method '세벌식' and ibus on Linux.
But commonly with different OSes and input methods, Hangul input in search gets trouble when committing a Hangul syllable.
I suspect that this is because viminum-c moves the input focus to other point in the page to mark the match.

To Reproduce

Steps to reproduce the behavior:

  1. Install Hangul input method on your OS
  2. Go to any Hangul site
  3. Type '/' and input any Hangul word in the page

Browser, OS and Vimium C versions

  • Browser name: Firefox
  • Browser version: 97.0, 99.0a1 (nightly) tested
  • Vimium C version: 1.96.6
  • OS name and version: Arch Linux, Gnome 41.3, IBus 1.5.25; Windows 11
@gdh1995
Copy link
Owner

gdh1995 commented Feb 22, 2022

Reproduced, but I haven't got any idea to fix it. Sorry...

@gdh1995
Copy link
Owner

gdh1995 commented Aug 10, 2022

Hello, Vimium C v1.99.0 now supports a new usage in FindMode:

  1. if only you type \0 (two characters of \ and '0), then it will "pause" and wait for a plain Enter key to continue instant searching
  2. so when you need to type Hangul characters, please try typing \0 first, and when you finish a word press Enter to let it do search again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants