Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "cyrillic fix" option #17

Closed
wants to merge 1 commit into from
Closed

Conversation

Kvis-Dev
Copy link

@Kvis-Dev Kvis-Dev commented Apr 6, 2018

Added "cyrillic fix" option, so users who have cyrillic keyboard layout don't have to switch layout to use this extension.

@gdh1995
Copy link
Owner

gdh1995 commented Apr 7, 2018

Thanks for your work, but I have some different opinions.

The function VKeyboard.getKeyChar is mainly used to compare its result with a user's mapped keys and link hint characters, and all of these keys and characters can be modified on the Vimium++ Options page.

Then, a user just need to add new key bindings into "Custom key mappings" and replace the "Characters used for link hints" with what's in the wanted keyboard layout. For example:

// Custom key mappings
map к reload
map а LinkHints.activate
map с previousTab
map м nextTab
map ш focusInput
......

// Characters used by link hints
фывпролд

The above should fix many keyboard layout issues, and as for the visual mode, mapKey directive is useful (e.g. mapKey м v). Although currently mapKey will also affect normal key mappings and make it too complicated to use both map and mapKey meanwhile, I'm reworking it soon and it won't be a big problem.

And then maybe the only left issue is some ede usages like translating <c-[> into <esc>, I'll fix such cases whenever they're found.

====================

Some advices about your code:

  • your cyrillics list doesn't consider about upper cases of characters
  • I'm trying to make source files in the lib folder independent, so VKeyboard should not use VSettings (you may set VKeyboard.*** in frontend.ts: requestHandlers.reset.

@gdh1995
Copy link
Owner

gdh1995 commented Aug 12, 2019

Closed, because I've merged the whole logic about ignoreKeyboardLayout in https://github.com/philc/vimium. Thanks anyway for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants