Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core extensions break .to_params #4

Closed
marcgg opened this issue Oct 19, 2010 · 2 comments
Closed

Core extensions break .to_params #4

marcgg opened this issue Oct 19, 2010 · 2 comments

Comments

@marcgg
Copy link

marcgg commented Oct 19, 2010

Hello,

I'm seeing a major issue in curb-fu

In file lib/curb-fu/core_ext.rb, it seems that curb-fu is extending the core. In that situation and as it is done here breaks some features of rails using .to_params

Example:

cache [object, something] #in a view

throws: /Users/x/.rvm/gems/ruby-1.8.7-p299/gems/curb-fu-0.4.4/lib/curb-fu/core_ext.rb:45:in `to_param'

This makes the whole gem unusable for me as it is. Also, no offense, but seeing core extensions like that cannot be a good sign...

Cheers

@gdi
Copy link
Collaborator

gdi commented Oct 27, 2010

Hey there!

Sorry it broke something in rails for you--it's most definitely not supposed to do that. I'd like a few more details about that error you're seeing, so if you get me some info about how to reproduce it I can make sure we don't break your gear :). We don't use this library internally with Rails.

In the meantime, I've committed a changeset that does a better (read: actual) job of not over-writing existing #to_param methods :), which I suspect is the problem here. It's here, if you want to try patching your gem: 0878123 .

Thanks for the report; sorry it took a couple days to get on it.

@hypomodern
Copy link
Contributor

I've recently merged a commit that should definitively solve this problem for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants