Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget color seems to be non-standard #663

Closed
Indemnity83 opened this issue Nov 7, 2023 · 1 comment
Closed

Widget color seems to be non-standard #663

Indemnity83 opened this issue Nov 7, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@Indemnity83
Copy link

I'm not sure if this is a "bug" or intended behavior, but the lock screen widget color doesn't appear to adjust to the standard/default colors as the phone moves through modes.

In light mode, with the screen unlocked the widget color looks ALMOST right, just slightly off and some may not notice. But if the phone is in dark mode, all other widgets get darker except OctoPod. Similarly, when the phone is locked with an always-on display the widget is STILL a relatively bright color.

I'm guessing that the color is hard-coded somewhere when it doesn't need to be?

I tried forking the repo and looking at the code myself, but I'm not an Ios Developer and got lost; if somebody can point me to the right place I'm glad to take a stab at a PR.

@gdombiak gdombiak added this to the 3.27 milestone Nov 16, 2023
@gdombiak gdombiak added the enhancement New feature or request label Nov 16, 2023
@gdombiak
Copy link
Owner

Hi Kyle,

Thanks for reporting this. You are correct in your assessment about having the color hardcoded. Let me know if you want to give it a take at a PR or if you want me to take care of this. The correct fix would be to consider the OctoPod setting for appearance. If you want to follow the system setting then color should change when using dark mode. If someone wants to always be light or dark mode then the backgroundcolor wouldn't change.

FYI, I'm planning to push next release out this week. If we cannot make it on time then I will include it in the next one.

Thanks,
Gaston

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants