Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a shortcut to run the code #40

Closed
xix-xeaon opened this issue Dec 29, 2021 · 7 comments
Closed

Add a shortcut to run the code #40

xix-xeaon opened this issue Dec 29, 2021 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@xix-xeaon
Copy link

Describe the bug
When you're in a "practice" you should be able to run the code without having to move your mouse. I expected to be able to use Ctrl+Enter to run the code, but it does not run.

@xix-xeaon xix-xeaon added the bug Something isn't working as intended label Dec 29, 2021
@YuriSizov
Copy link
Contributor

We are discussing having more shortcuts, however, the app and the course is designed for absolute beginners, who would not expect that to be the workflow. So this may end up causing confusion if they do hit a shortcut accidentally.

@NathanLovato NathanLovato added enhancement New feature or request and removed bug Something isn't working as intended labels Dec 29, 2021
@NathanLovato
Copy link
Contributor

Yup, I was thinking of something more like Ctrl+R or Ctrl+Shift+R. Let's see. In any case, it's not a bug.

@NathanLovato NathanLovato changed the title Ctrl+Enter should run the code Add a shortcut to run the code Dec 29, 2021
@xix-xeaon
Copy link
Author

I can understand that. I think this would be a good idea though because it makes it more interactive. I was also considering if the app should validate / run the code automatically all the time.

I know my students are sometimes confused when the Godot editor shows errors simply because they've not finished typing, but on the other hand it also gives instant feedback when they make mistakes or get it right.

When you get to the more "complicated" practice problems that have several steps in them, having the run window continuously show what you've done so far is very good feedback.

Maybe ctrl+enter seems like it could be a nice balance (and much easier implemented).

@YuriSizov
Copy link
Contributor

Any shortcut would be equally easy to implement 🙃 Adding them, however, raises a question of discoverability, as we'd need to teach them to users, whether as a part of the interactive tutorial for the app, or as a separate screen with a cheat sheet.

@NathanLovato
Copy link
Contributor

That's the idea, somewhere between #11, #28, and #29.

@NathanLovato NathanLovato added this to the 0.2 milestone Dec 29, 2021
@generrosity
Copy link

One vote for 'align with Godot' - you could capture and use "F5" the same way Godot web editor does. Perhaps surface as button hover tip and include in later Godot UI 'why all the funky colours?' lessons. I see you already prevent web F5/F12 functionality.

MSOutlook surfaces this by detecting it, and asking how to act. It otherwise buries the option. For Godot you could capture the control-enter and popup an explaination or feature enablement.

Also, you could surface the same way GitHub surfaces Markdown tips as a subtle icon in a corner. But I like this option the least.
image

@NathanLovato
Copy link
Contributor

#90 supersedes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants