-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop-in directory is ignored #51
Comments
I find out that there is already support for this feature implemented here. But it doesn't work with the kubadm drop-in for any reason. docker-systemctl-replacement v1.4.2456 |
Yes, the feature is implemented and I have seen it to work properly. So it would be interesting to see which value is considered to be wrong. Would you mind to attach the relevant files? (may be with passwords xxxed). Any idea what values should be different? Also check the output of the properties like
|
By the way, I do see now that there is a different directory prefix. Would you mind moving the config file into a different path like
|
This is exactly the content of
|
Moving to |
I have started to check into that
So, it is actually two problems
|
Actually, my testcases war partially wrong. The systemd config reader is just fine, but I noticed from your example that is was missing the option to reset a value by giving an emtpy line in the xx.service descriptor. That is also tested in test_8051 now. The test_8052 will check your specific kubelet example, so it should work in your setup as expected by now - at version v1.4.2505 |
I tested it with version v1.4.2505 and it worked like a charme. There should be more people like you. Thank you for the great support! |
I have started to create a number of testcases to cover the drop-in functionalty..... however try-and-error did show that systemd will check all systemd directories but it will ignore some drop-in files. It seems that the drop-in files are loaded alphabetically by filename, and if the filename exists in multiple override.d directories then only the uppermost is used, mostly /etc stuff. That did require a complete reimplementation as for v1.4.2521 |
I guess it is fixed now. |
Manpage of systemd.unit describes an optional drop-in directory for systemd unit files:
This files are ignored.
An example is Kubernetes, which installs files in drop-in directories.
installs the following files:
The command
doesn't take
10-kubeadm.conf
into account and kubelet service starts with wrong parameters.The text was updated successfully, but these errors were encountered: