This repository has been archived by the owner on Nov 23, 2020. It is now read-only.
[#64043152] Use core gem #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is now in bin. I haven't removed the documentation for now - we need to tidy this all up at some point but there's no harm in it being duplicated for now, as vcloud-query can still be used via vcloud-tools.
|
Looks fine to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests pass, integration tests passes and it seems to work. However, this needs testing and reviewing very carefully because we don't want to break anything. Ideally this should have no impact on the users at all.
Does it still work for the way IDA are working with the tools? Also to check there are no files that are now both in this repository and https://github.com/alphagov/vcloud-core (if so, they should be removed from here).