New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#64043152] Use core gem #116

Merged
merged 5 commits into from Jan 20, 2014

Conversation

Projects
None yet
2 participants
@annashipman
Contributor

annashipman commented Jan 17, 2014

Unit tests pass, integration tests passes and it seems to work. However, this needs testing and reviewing very carefully because we don't want to break anything. Ideally this should have no impact on the users at all.

Does it still work for the way IDA are working with the tools? Also to check there are no files that are now both in this repository and https://github.com/alphagov/vcloud-core (if so, they should be removed from here).

annashipman and others added some commits Jan 17, 2014

[#64043152] Remove vcloud-query executable
As it is now in bin. I haven't removed the documentation for now - we need to tidy this all up at some point but there's no harm in it being duplicated for now, as vcloud-query can still be used via vcloud-tools.
@mikepea

This comment has been minimized.

Contributor

mikepea commented Jan 20, 2014

Looks fine to me.

mikepea added a commit that referenced this pull request Jan 20, 2014

@mikepea mikepea merged commit f99410e into master Jan 20, 2014

@annashipman annashipman deleted the use-core-gem branch Jan 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment