Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHAPTER: Weights #26

Closed
darribas opened this issue Jun 30, 2019 · 5 comments
Closed

CHAPTER: Weights #26

darribas opened this issue Jun 30, 2019 · 5 comments
Labels
chapter with publisher
Projects
Finishing the Book

Comments

@darribas
Copy link
Member

Thread to discuss chapter on Spatial Weights. It picks discussion up from gds#40.
@darribas darribas added chapter finished has been sent to publisher and revisions completed labels Jun 30, 2019
@ljwolf ljwolf added this to Revision in Finishing the Book Nov 24, 2020
@ljwolf ljwolf added needs revision needs to be revised according to publisher feedback and removed finished has been sent to publisher and revisions completed labels Nov 24, 2020
@darribas darribas mentioned this issue Nov 27, 2020
Closed
@darribas darribas self-assigned this Jun 23, 2021
@darribas
Copy link
Member Author

darribas commented Jun 23, 2021 •
edited by ljwolf
Loading

Final pass:

  • Dani
  • Serge
  • Levi

@darribas
Copy link
Member Author

darribas commented Jun 23, 2021 •
edited
Loading

Dani final pass tracker, to be edited as we go along:

Things to ensure (from #152 ):

  • Library imports (first time inline, afterwards at the top of the chapter
  • No aliases on imports (import pandas)
  • Ensure no XXX for citations
  • Ensure matplotlib RC file is picked up and figures are standard
  • Remove %matplotlib inline
  • Graphics
    • No style
    • No title (unless multi-axis titles, but not suptitle)
    • No axes for maps (ax.set_axis_off())
  • Code comments are fine if needed
  • Hide/remove code cells that we want to hide (see docs here)
  • Typesetting check
  • General flow of the text
  • Ensure there is a "next step" section at the end of the chapter pointing to further references for the topic (re. Further references standardisation #137)

@darribas
Copy link
Member Author

darribas commented Jul 9, 2021 •
edited
Loading

Notes from my review (to be updated as I go along):

  • I've streamlined the visualisation section because I though there was too much repetition and not enough content (I've added KNN to the figure for completion)
  • My sense is that the use case with boundaries is well above the level of the book, both conceptually and technically. There are snippets I struggle to read through... But I think it's interesting enough it's worth leaving in. I've added a sentence at the beginning signposting this so readers don't freak out.

@darribas darribas mentioned this issue Jul 9, 2021
Merged
@darribas
Copy link
Member Author

darribas commented Jul 9, 2021

Edits from @darribas ready at #182, ready to merge by @sjsrey / @ljwolf

@darribas darribas removed their assignment Jul 9, 2021
@ljwolf ljwolf added final edits and removed needs revision needs to be revised according to publisher feedback labels Jul 19, 2021
@ljwolf ljwolf self-assigned this Sep 15, 2021
@sjsrey
Copy link
Contributor

sjsrey commented Sep 17, 2021

For Further Reading:

2 chapters Anselin and Rey

https://onlinelibrary.wiley.com/doi/10.1111/tesg.12480

@ljwolf ljwolf moved this from Revision to Waiting to send to publisher in Finishing the Book Nov 18, 2021
@ljwolf ljwolf removed their assignment Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chapter with publisher
Projects
Finishing the Book
Needs additional reading
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sjsrey @darribas @ljwolf